goal clerk inspect: more base32+checksum fixes#24
Conversation
Actually display the checksum for multisig PKs; also display txn Sender, Receiver, and CloseRemainderTo using the same address encoding; and fix the counter for displaying multiple txns in a file.
Karmastic
left a comment
There was a problem hiding this comment.
Since we have some time for this, can you add a test or 2 that will catch changes to types that will cause your built-in validation to fail?
I added some positive tests. What did you have in mind for catching failures? I believe it requires either changing the SignedTxn type (or its children, like Transaction), or breaking the code in |
Karmastic
left a comment
There was a problem hiding this comment.
Thanks - looks great. The tests should catch struct changes early.
Actually display the checksum for multisig PKs; also display txn Sender, Receiver, and CloseRemainderTo using the same address encoding; and fix the counter for displaying multiple txns in a file.
Print hash of approval and clear programs on creation.
Actually display the checksum for multisig PKs; also display txn Sender,
Receiver, and CloseRemainderTo using the same address encoding; and fix
the counter for displaying multiple txns in a file.