Skip to content

goal clerk inspect: more base32+checksum fixes#24

Merged
zeldovich merged 2 commits intoalgorand:masterfrom
zeldovich:clerk-inspect
Jun 14, 2019
Merged

goal clerk inspect: more base32+checksum fixes#24
zeldovich merged 2 commits intoalgorand:masterfrom
zeldovich:clerk-inspect

Conversation

@zeldovich
Copy link
Copy Markdown
Contributor

Actually display the checksum for multisig PKs; also display txn Sender,
Receiver, and CloseRemainderTo using the same address encoding; and fix
the counter for displaying multiple txns in a file.

Actually display the checksum for multisig PKs; also display txn Sender,
Receiver, and CloseRemainderTo using the same address encoding; and fix
the counter for displaying multiple txns in a file.
Copy link
Copy Markdown
Contributor

@Karmastic Karmastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have some time for this, can you add a test or 2 that will catch changes to types that will cause your built-in validation to fail?

@zeldovich
Copy link
Copy Markdown
Contributor Author

Since we have some time for this, can you add a test or 2 that will catch changes to types that will cause your built-in validation to fail?

I added some positive tests. What did you have in mind for catching failures? I believe it requires either changing the SignedTxn type (or its children, like Transaction), or breaking the code in inspect.go. Neither seems like it can be cleanly localized in a unit test, and I don't think polluting the real SignedTxn or Transaction types with extra test-only fields is worth it for this test.

Copy link
Copy Markdown
Contributor

@Karmastic Karmastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - looks great. The tests should catch struct changes early.

@zeldovich zeldovich merged commit e4dc33a into algorand:master Jun 14, 2019
@zeldovich zeldovich deleted the clerk-inspect branch June 14, 2019 19:10
Karmastic pushed a commit that referenced this pull request Jun 20, 2019
Actually display the checksum for multisig PKs; also display txn Sender,
Receiver, and CloseRemainderTo using the same address encoding; and fix
the counter for displaying multiple txns in a file.
derbear pushed a commit to derbear/go-algorand that referenced this pull request Mar 25, 2020
Print hash of approval and clear programs on creation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants