Skip to content

Re-enable integration tests.#14

Merged
winder merged 1 commit intoalgorand:masterfrom
winder:will/enable-integration-tests
Jun 13, 2019
Merged

Re-enable integration tests.#14
winder merged 1 commit intoalgorand:masterfrom
winder:will/enable-integration-tests

Conversation

@winder
Copy link
Copy Markdown
Contributor

@winder winder commented Jun 13, 2019

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 13, 2019

CLA assistant check
All committers have signed the CLA.

@winder winder requested a review from derbear June 13, 2019 17:53
Copy link
Copy Markdown
Contributor

@algoradam algoradam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming integrations pass again, looks good to me! (Also, maybe ask someone whether test_running_install_and_update.sh is safe to delete now)

@derbear
Copy link
Copy Markdown
Contributor

derbear commented Jun 13, 2019

Also, maybe ask someone whether test_running_install_and_update.sh is safe to delete now

@Karmastic ?

@winder
Copy link
Copy Markdown
Contributor Author

winder commented Jun 13, 2019

@algoradam If you click through to travis, it's running the integration tests.
@derbear I'm going to ask around about that test, for now I wanted to make sure we didn't throw the baby out with the bath water by disabling other tests.

@winder winder merged commit e91385f into algorand:master Jun 13, 2019
pzbitskiy pushed a commit to pzbitskiy/go-algorand that referenced this pull request Mar 18, 2020
@winder winder deleted the will/enable-integration-tests branch August 11, 2020 18:09
michaeldiamant pushed a commit to michaeldiamant/go-algorand that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants