Make account changeonlinestatus online flag optional#1170
Make account changeonlinestatus online flag optional#1170tsachiherman merged 4 commits intoalgorand:masterfrom
Conversation
tsachiherman
left a comment
There was a problem hiding this comment.
The change itself is fine, but it's missing the corresponding unit test.
The unit test should be one that fails without the goal change and passes with.
( i.e. the unit test should cover the correct behavior of goal utility in regards to this command )
|
@tsachiherman There is an integration test for this today, which uncovered the issue as part of the Jenkins/Mule integration work. The test is: test/e2e-go/cli/goal/expect/listExpiredParticipationKeyTest.exp |
Yes, but this integration test is clearly broken. Otherwise, it would have failed before. For this PR to be complete, it should demonstrate the not passing the "online" flag at all is equivalent to passing a "online true", as well as that the "online false" is working as expected. |
I'm dismissing my change requests since my upcoming change would include a fix for this issue.
Summary
Since the
onlineoption in thegoal account changeonlinestatusdefaults to true, updated the command so that theonlineoption is not required.Test Plan
Ran
make testandmake integration.