Remove old buggy version of proposal LowestOutput#1094
Merged
derbear merged 1 commit intoalgorand:masterfrom Jun 25, 2020
Merged
Remove old buggy version of proposal LowestOutput#1094derbear merged 1 commit intoalgorand:masterfrom
derbear merged 1 commit intoalgorand:masterfrom
Conversation
Now that the protocol upgrade fixing the bug has gone through, we no longer need to keep the buggy version around for compatibility.
Contributor
|
Looks good; I'd suggest we'll run this change via a complete catchup so that we can ensure it won't cause any unexpected catchup issues. |
Contributor
|
@derbear could you please review this and see if we could close this one ? |
Contributor
|
The plan is to merge but only after the pending June mainnet release is set. |
derbear
approved these changes
Jun 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the protocol upgrade fixing the bug has gone through, we no longer need to keep the buggy version around for compatibility.