Skip to content

Move travis to 18.04#104

Merged
Karmastic merged 4 commits intomasterfrom
david/moveTo1804
Jun 29, 2019
Merged

Move travis to 18.04#104
Karmastic merged 4 commits intomasterfrom
david/moveTo1804

Conversation

@Karmastic
Copy link
Copy Markdown
Contributor

We want to start building and testing devnet (nightly) on Ubuntu 18.04 so we can move production to it after more testing.
Remove building of debian package - it's now done for release builds only.
Remove GATE_PREFIX - we'll use separate buckets for the same purpose.

NOTE: This will fail to install and run on CentOS due to an obsolete glibc version in CentOS.

We want to start building and testing devnet (nightly) on Ubuntu 18.04 so we can move production to it after more testing.
Remove building of debian package - it's now done for release builds only.
Remove GATE_PREFIX - we'll use separate buckets for the same purpose.
@Karmastic Karmastic requested a review from algobolson June 28, 2019 09:59
Comment thread scripts/build_packages.sh
tar -zcf ${PKG_ROOT}/${GATE_PREFIX}tools_${CHANNEL}_${PKG_NAME}_${FULLVERSION}.tar.gz * >/dev/null 2>&1
tar -zcf ${PKG_ROOT}/tools_${CHANNEL}_${PKG_NAME}_${FULLVERSION}.tar.gz * >/dev/null 2>&1
popd

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build_release.sh calls build_packages.sh and expects that to build the .deb
we could turn it off here with a variable test, e.g. if [ ! -z "${BUILD_DEB}" ]; or so

@tsachiherman
Copy link
Copy Markdown
Contributor

I think that our goal should be expanding our supported platform base rather than shrinking it..
What would it take to have a "special build" for RedHat/CentOS builds ?

@algobolson
Copy link
Copy Markdown
Contributor

ubuntu 16.04 is supposed to get maintenance upgrades through 2020 ( https://ubuntu.com/about/release-cycle ), but we don't have to support it that long. Moving to newer systems makes things easier for us because they have newer versions of things installed with bug fixes and nicer features. The release build should continue to support Ubuntu 18.04 and Centos 7.

We still use the script in build_packages.sh to generate the deb package for production release builds; make it optional and have those builds enable it.
@Karmastic
Copy link
Copy Markdown
Contributor Author

I think that our goal should be expanding our supported platform base rather than shrinking it..
What would it take to have a "special build" for RedHat/CentOS builds ?

I'm going to exercise our RPM package for R1 and R2, our CentOS machines. They'll be supported - they just won't support the installer (unless the user wants to build glibc for CentOS 7 themselves)

Comment thread scripts/build_packages.sh Outdated
fi
pushd ${DEBTMP}
cp -p *.deb ${PKG_ROOT}/${GATE_PREFIX}algorand_${CHANNEL}_${PKG_NAME}_${FULLVERSION}.deb
cp -p *.deb ${PKG_ROOT}/${GATE_PREFIX}algorand_${CHANNEL}_${PKG_NAME}_${FULLVERSION}.deb
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more GATE_PREFIX

Was a nop but doesn't belong anymore
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Karmastic
❌ David Shoots


David Shoots seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Karmastic Karmastic merged commit 8f06f20 into master Jun 29, 2019
@Karmastic Karmastic deleted the david/moveTo1804 branch June 29, 2019 09:03
algorandskiy pushed a commit to algorandskiy/go-algorand that referenced this pull request Jun 2, 2020
…l_test

Add test for `prepareAppEvaluators`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants