Skip to content

bug-fix: include currency-greater-than param for 0 value#584

Merged
shiqizng merged 4 commits intodevelopfrom
shiqi/params
Aug 10, 2023
Merged

bug-fix: include currency-greater-than param for 0 value#584
shiqizng merged 4 commits intodevelopfrom
shiqi/params

Conversation

@shiqizng
Copy link
Copy Markdown
Contributor

@shiqizng shiqizng commented Aug 7, 2023

This PR fixes #583

@shiqizng shiqizng requested a review from a team August 7, 2023 20:13
@shiqizng shiqizng self-assigned this Aug 7, 2023
Comment thread .test-env Outdated
algochoi
algochoi previously approved these changes Aug 8, 2023
Copy link
Copy Markdown
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but let's revert to main v2 testing branch before merge

@shiqizng shiqizng requested a review from a team August 10, 2023 13:55
Copy link
Copy Markdown
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generated code, so there needs to be a corresponding change here: https://github.com/algorand/generator/

@algochoi algochoi self-requested a review August 10, 2023 15:52
@algochoi algochoi dismissed their stale review August 10, 2023 15:52

Generator changes

@shiqizng
Copy link
Copy Markdown
Contributor Author

Ran the generator. Included all the updated files.

@shiqizng shiqizng requested a review from winder August 10, 2023 19:54
@shiqizng shiqizng merged commit 0865549 into develop Aug 10, 2023
@shiqizng shiqizng deleted the shiqi/params branch August 10, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Valid GET parameter of 0 filtered out

5 participants