build: Bump golang to 1.17 #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why the langspec change, can it be omitted? |
|
Yeah I looked into the langspec change and it seems like for some reason the updates don't like the line length of the previous commit. So each line is shortened by one entry, but they're functionally the same. It just gets regenerated like that during build if you checkout HEAD so I just included it. |
|
Alternatively we could opt to use |
winder
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping golang version to 1.17 to bring the go-sdk into parity with the go-algorand repository update happening in algorand/go-algorand#3919
build/test works and I've updated and run the docker tests as well.