adding go teal compile option changes#37
Merged
Conversation
Eric-Warehime
approved these changes
Jul 12, 2022
michaeldiamant
approved these changes
Jul 13, 2022
Contributor
michaeldiamant
left a comment
michaeldiamant
left a comment
There was a problem hiding this comment.
@barnjamin Thanks for finding a way forward here. ☕
- I confirmed the generated changes produce no diff with algorand/go-algorand-sdk#335 as of algorand/go-algorand-sdk@2c673b2.
- Out of scope to the PR: I opened an issue because it feels to me that a more robust solution is warranted - #38.
winder
suggested changes
Jul 13, 2022
Contributor
winder
left a comment
winder
left a comment
There was a problem hiding this comment.
We shouldn't add special cases in new endpoints. The special cases elsewhere were done for backwards compatibility and will be removed in a future major release.
michaeldiamant
approved these changes
Jul 20, 2022
Contributor
michaeldiamant
left a comment
michaeldiamant
left a comment
There was a problem hiding this comment.
As of c5fb80f and as expected, I confirmed re-generating Go SDK produces no diffs in algorand/go-algorand-sdk#335.
Contributor
|
Merging - Based on a verbal with @winder, we agreed I can merge provided I'm comfortable with the diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done in order to pass a GET parameter through the Go client for TEAL compile endpoint