Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

refactor(lodash): orderBy #2462

Merged
merged 11 commits into from
Jun 25, 2019
Merged

refactor(lodash): orderBy #2462

merged 11 commits into from
Jun 25, 2019

Commits on May 24, 2019

  1. refactor(lodash): orderBy 

    The utility is copied from the helper (which passed all lodash tests), I put it inline in the connector, since it's not used in any other spot.

IFW-746
    @Haroenv
    Haroenv committed May 24, 2019
    Configuration menu
    Copy the full SHA
    af37a12 View commit details
    Browse the repository at this point in the history

  2. refactor(menu): remove orderBy & use helper method 

    These tests provide no security at all, but this change in behaviour can be confirmed in the stories.
    @Haroenv
    Haroenv committed May 24, 2019
    Configuration menu
    Copy the full SHA
    adbe458 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2019

  1. chore(indexUtils): make usage simpler 

    I caught this when trying to refactor the tests to use a real helper, but eventually decided not to do that
    @Haroenv
    Haroenv committed May 27, 2019
    Configuration menu
    Copy the full SHA
    1ad6f6e View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. chore: update test name

    @Haroenv
    Haroenv committed May 28, 2019
    Configuration menu
    Copy the full SHA
    540334b View commit details
    Browse the repository at this point in the history

  2. chore: different if style

    @Haroenv
    Haroenv committed May 28, 2019
    Configuration menu
    Copy the full SHA
    344593e View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. chore(test): simplify

    @Haroenv
    Haroenv committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    b335830 View commit details
    Browse the repository at this point in the history

  2. chore: update sizes

    @Haroenv
    Haroenv committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    b48459e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'v6' into lodash/orderBy

    @Haroenv
    Haroenv authored Jun 25, 2019
    Configuration menu
    Copy the full SHA
    62f95a2 View commit details
    Browse the repository at this point in the history

  4. chore(size): looser limit

    @Haroenv
    Haroenv committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    0cd69fa View commit details
    Browse the repository at this point in the history

  5. simplify code

    @Haroenv
    Haroenv committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    eb0cf5c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'v6' into lodash/orderBy

    @Haroenv
    Haroenv authored Jun 25, 2019
    Configuration menu
    Copy the full SHA
    db01075 View commit details
    Browse the repository at this point in the history