fix(compat): upgrade Panel lifecycle

algolia · Apr 8, 2019 · d7128dc · d7128dc
1 parent 5ff2f51
commit d7128dc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/packages/react-instantsearch-dom/src/components/PanelCallbackHandler.js b/packages/react-instantsearch-dom/src/components/PanelCallbackHandler.js
@@ -11,20 +11,18 @@ class PanelCallbackHandler extends Component {
     setCanRefine: PropTypes.func,
   };
 
-  componentWillMount() {
-    // @TODO: didMount? -> really test this
+  componentDidMount() {
     if (this.context.setCanRefine) {
       this.context.setCanRefine(this.props.canRefine);
     }
   }
 
-  componentWillReceiveProps(nextProps) {
-    // @TODO: DidUpdate
+  componentDidUpdate(prevProps) {
     if (
       this.context.setCanRefine &&
-      this.props.canRefine !== nextProps.canRefine
+      prevProps.canRefine !== this.props.canRefine
     ) {
-      this.context.setCanRefine(nextProps.canRefine);
+      this.context.setCanRefine(this.props.canRefine);
     }
   }
 

diff --git a/packages/react-instantsearch-dom/src/components/__tests__/PanelCallbackHandler.js b/packages/react-instantsearch-dom/src/components/__tests__/PanelCallbackHandler.js
@@ -20,7 +20,7 @@ describe('PanelCallbackHandler', () => {
     expect(wrapper).toMatchSnapshot();
   });
 
-  describe('willMount', () => {
+  describe('didMount', () => {
     it('expect to call setCanRefine when the context is given', () => {
       const props = {
         canRefine: true,
@@ -57,7 +57,7 @@ describe('PanelCallbackHandler', () => {
     });
   });
 
-  describe('willReceiveProps', () => {
+  describe('didUpdate', () => {
     it('expect to call setCanRefine when the context is given', () => {
       const props = {
         canRefine: true,