fix: warn about invalid userToken #4605
Conversation
eunjae-lee
force-pushed
the
fix/invalid-user-token
branch
from
1e97ef7 to
adcbc81
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c9916e9:
|
ghost
requested review from
shortcuts and
yannickcr
and removed request for
a team
yarn.lock
Outdated
| @@ -2919,27 +2919,6 @@ [email protected]: | |||
| "@algolia/requester-node-http" "4.8.2" | |||
| "@algolia/transporter" "4.8.2" | |||
|
|
|||
| algoliasearch@^3.35.1: | |||
There was a problem hiding this comment.
unfortunately you need to keep this entry in the lock file, otherwise algoliasearch-v3 won't build anymore in storybook as far as I can tell (it doesn't deal properly with the aliased module + places.js having a dependency
There was a problem hiding this comment.
Not sure why it got deleted.
There was a problem hiding this comment.
Yarn thinks this is the right resolution (since it deduplicates), but some other tools try to use the node_modules folder name, which is algoliasearch-v3 if it gets deduplicated
yarn.lock
Outdated
| dependencies: | ||
| events "^1.1.1" | ||
|
|
||
| "algoliasearch-v3@npm:[email protected]": | ||
| "algoliasearch-v3@npm:[email protected]", algoliasearch@^3.35.1: |
There was a problem hiding this comment.
@Haroenv This line has changed too. Do you think I should revert it?
There was a problem hiding this comment.
yes, you should revert it too.
eunjae-lee
force-pushed
the
fix/invalid-user-token
branch
from
adcbc81 to
c9916e9
Compare
Summary
This PR updates
algoliasearch-helperto 3.3.4 to warn users about invalid userToken.