fix(insights): use internal find util method
#4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
shortcuts and
yannickcr
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 95dd6e5:
|
yannickcr
approved these changes
Nov 17, 2020
shortcuts
approved these changes
Nov 17, 2020
|
I'll think if we can add a browser compat test, since the e2e test clearly doesn't catch this |
|
I'm wondering how the e2e tests were successful in IE env in the first place. |
|
Wondering too... |
|
the insights middleware must not have been used on the e2e test @eunjae-lee otherwise maybe too many polyfills were enabled? |
that must be it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #4575 we introduced a regression in IE because we used the native
findmethod instead of our internal util.Related