Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): do not throw when sending event right after creating insights middleware #4575

Merged
merged 8 commits into from
Nov 12, 2020
Merged

fix(insights): do not throw when sending event right after creating insights middleware #4575

merged 8 commits into from
Nov 12, 2020

Commits on Nov 9, 2020

  1. test: test if insightsClient does not throw when an event is sent rig… 

    …ht after creating the middleware
    @eunjae-lee
    eunjae-lee committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    97244a5 View commit details
    Browse the repository at this point in the history

  2. fix: restore user token which was set before creating the middleware

    @eunjae-lee
    eunjae-lee committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    9effefd View commit details
    Browse the repository at this point in the history

  3. test: make it clearer

    @eunjae-lee
    eunjae-lee committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    1d3c977 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. use find instead of loop

    @eunjae-lee
    eunjae-lee committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    fa7ea26 View commit details
    Browse the repository at this point in the history

  2. add queue to InsightsClient type

    @eunjae-lee
    eunjae-lee committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    5ddedee View commit details
    Browse the repository at this point in the history

  3. clean up flow

    @eunjae-lee
    eunjae-lee committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    8b10f89 View commit details
    Browse the repository at this point in the history

  4. change the way to test viewedObjectIDs

    @eunjae-lee
    eunjae-lee committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    0add3dc View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into fix/insights-init

    Eunjae Lee authored Nov 12, 2020
    Configuration menu
    Copy the full SHA
    b3e0247 View commit details
    Browse the repository at this point in the history