chore(v3): remove URLSync #3143
Conversation
|
Deploy preview for algolia-instantsearch ready! Built with commit 26121ec https://deploy-preview-3143--algolia-instantsearch.netlify.com |
src/lib/InstantSearch.js
Outdated
| @@ -226,7 +206,7 @@ class InstantSearch extends EventEmitter { | |||
| // We don't want to re-add URlSync `getConfiguration` widget | |||
| // it can throw errors since it may re-add SearchParameters about something unmounted | |||
| this.searchParameters = this.widgets | |||
| .filter(w => w.constructor.name !== 'URLSync') | |||
| .filter(w => w.constructor.name !== 'URLSync') // TODO: check the routing for this | |||
There was a problem hiding this comment.
Can we check this now?
There was a problem hiding this comment.
There is no issue as far as I can test with the current behavior. I'm getting rid of it.
src/lib/InstantSearch.js
Outdated
| @@ -205,9 +205,9 @@ class InstantSearch extends EventEmitter { | |||
| if (nextState) { | |||
| // We don't want to re-add URlSync `getConfiguration` widget | |||
| // it can throw errors since it may re-add SearchParameters about something unmounted | |||
| this.searchParameters = this.widgets | |||
| .filter(w => w.constructor.name !== 'URLSync') // TODO: check the routing for this | |||
There was a problem hiding this comment.
Just to let you know, we can't use the name attribute of function or constructor. Once Uglify pass on the code all values are renamed and the constructor name is changed (except with an Uglify option that is by default to false, see keep_fnames ).
There was a problem hiding this comment.
That's good to know thanks. It might have never worked in production then for the URLSync.
|
The doc is now updated |
|
Linting is failign in this PR :) |
Linting never sleeps :) |
This PR removes the URLSync.
This PR depends on #3148 to be fixed.