Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): generate common LICENSE #3258

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2525

Changes included:

most clients don't have a LICENSE, we now have one at the root of the template folder with a symlink in each client to generate it

@shortcuts shortcuts self-assigned this Jun 26, 2024
@shortcuts shortcuts requested a review from a team as a code owner June 26, 2024 11:26
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 26, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Fluf22
Fluf22 previously approved these changes Jun 26, 2024
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@shortcuts
Copy link
Member Author

ah bah the generator don't want symlink either :(

Copy link

github-actions bot commented Jun 26, 2024

@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 12:13 Inactive
@shortcuts shortcuts enabled auto-merge (squash) June 26, 2024 14:47
Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 15:51 Inactive
@shortcuts shortcuts merged commit e5cfcf0 into main Jun 26, 2024
21 checks passed
@shortcuts shortcuts deleted the feat/clients-generate-mit-license branch June 26, 2024 15:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants