Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): virtual is a fetchedIndex props #3255

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix(specs): virtual is a fetchedIndex props #3255

merged 2 commits into from
Jun 26, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

the property introduced in #3254 is an index property, not an index settings

@shortcuts shortcuts self-assigned this Jun 25, 2024
@shortcuts shortcuts requested a review from a team as a code owner June 25, 2024 19:02
@shortcuts shortcuts mentioned this pull request Jun 25, 2024
Merged
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 25, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@github-actions GitHub Actions
Copy link

🚀 Deployed on https://667b1a577bb2cc5df3999885--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 25, 2024 19:28 Inactive
Fluf22
Fluf22 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, big diff

@shortcuts shortcuts merged commit 5dbdb91 into main Jun 26, 2024
21 checks passed
@shortcuts shortcuts deleted the fix/specs-virtual branch June 26, 2024 07:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fluf22 Fluf22 Fluf22 approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @Fluf22