Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): reduce common tests flakyness #3205

Merged
merged 3 commits into from
Jun 18, 2024
Merged

fix(clients): reduce common tests flakyness #3205

merged 3 commits into from
Jun 18, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jun 18, 2024

🧭 What and Why

🎟 JIRA Ticket: DI-2467

The tests servers were shared across all tests, so if 1 finishes earlier it can make the other fail.

@millotp millotp self-assigned this Jun 18, 2024
@millotp millotp requested a review from a team as a code owner June 18, 2024 14:12
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 18, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link

github-actions bot commented Jun 18, 2024

@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 14:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 15:10 Inactive
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@github-actions github-actions bot temporarily deployed to pull request June 18, 2024 20:36 Inactive
@shortcuts shortcuts merged commit 9ad5c8c into main Jun 18, 2024
12 checks passed
@shortcuts shortcuts deleted the fix/js-flaky branch June 18, 2024 20:57
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jun 18, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants