Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recommend): export recommend methods to use them in algoliasearch #1512

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Mar 26, 2024

In 8087b28, we import methods from @algolia/recommend into algoliasearch to give direct access to recommendations from the search client.

The CJS bundle for @algolia/recommend did not export the methods, only the recommend() method to set up a recommend client. This caused an issue in the v4.23.0 release of algoliasearch as it basically imported undefined methods, which prevented the correct instantiation of the search client.

This PR reexports all methods to ensure they are present when imported by algoliasearch.

It also tests the built algoliasearch bundles, inspired by what we have in InstantSearch.

Fixes #1511

@dhayab dhayab force-pushed the fix/recommend-methods-exports branch from db0ab1d to 6e7e587 Compare March 26, 2024 14:46
@dhayab dhayab requested review from a team and Haroenv March 26, 2024 14:49
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks for jumping on it!

@dhayab dhayab merged commit 5fc5f4f into master Mar 26, 2024
5 of 8 checks passed
@dhayab dhayab deleted the fix/recommend-methods-exports branch March 26, 2024 15:09
renovate bot added a commit to simonknittel/sinister-incorporated that referenced this pull request Apr 4, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[algoliasearch](https://github.com/algolia/algoliasearch-client-javascript)
| [`4.22.1` ->
`4.23.2`](https://renovatebot.com/diffs/npm/algoliasearch/4.22.1/4.23.2)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/algoliasearch/4.23.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/algoliasearch/4.23.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/algoliasearch/4.22.1/4.23.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/algoliasearch/4.22.1/4.23.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>algolia/algoliasearch-client-javascript
(algoliasearch)</summary>

###
[`v4.23.2`](https://github.com/algolia/algoliasearch-client-javascript/blob/HEAD/CHANGELOG.md#v4232)

[Compare
Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.23.1...4.23.2)

- fix(recommend): only export default function
([#&#8203;1514](https://github.com/algolia/algoliasearch-client-javascript/issues/1514))
([4a04d8e](https://github.com/algolia/algoliasearch-client-javascript/commits/4a04d8e)),
closes
[#&#8203;1514](https://github.com/algolia/algoliasearch-client-javascript/issues/1514)

###
[`v4.23.1`](https://github.com/algolia/algoliasearch-client-javascript/blob/HEAD/CHANGELOG.md#v4231)

[Compare
Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.23.0...4.23.1)

- fix(recommend): export recommend methods to use them in algoliasearch
([#&#8203;1512](https://github.com/algolia/algoliasearch-client-javascript/issues/1512))
([5fc5f4f](http://algolia/algoliasearch-client-javascript/commits/5fc5f4f)),
closes
[#&#8203;1512](http://algolia/algoliasearch-client-javascript/issues/1512)

###
[`v4.23.0`](https://github.com/algolia/algoliasearch-client-javascript/blob/HEAD/CHANGELOG.md#v4230)

[Compare
Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.22.1...4.23.0)

- feat(search): fetch recommendations directly from algoliasearch
([#&#8203;1509](https://github.com/algolia/algoliasearch-client-javascript/issues/1509))
([8087b28](http://algolia/algoliasearch-client-javascript/commits/8087b28)),
closes
[#&#8203;1509](http://algolia/algoliasearch-client-javascript/issues/1509)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/simonknittel/sinister-incorporated).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
convex-copybara bot pushed a commit to get-convex/convex-backend that referenced this pull request Jan 29, 2025
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [algoliasearch](https://github.com/algolia/algoliasearch-client-javascript/packages/algoliasearch#readme) ([source](https://github.com/algolia/algoliasearch-client-javascript)) | dependencies | minor | [`~4.20.0` -> `~4.24.0`](https://renovatebot.com/diffs/npm/algoliasearch/4.20.0/4.24.0) |

---

### Release Notes

<details>
<summary>algolia/algoliasearch-client-javascript (algoliasearch)</summary>

### [`v4.24.0`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.24.0)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.23.3...4.24.0)

-   chore: release v4.24.0 ([#&#8203;1528](https://github.com/algolia/algoliasearch-client-javascript/issues/1528)) ([9f8956c](https://github.com/algolia/algoliasearch-client-javascript/commit/9f8956c)), closes [#&#8203;1528](https://github.com/algolia/algoliasearch-client-javascript/issues/1528)
-   chore: revert "chore: release v4.24.0 ([#&#8203;1528](https://github.com/algolia/algoliasearch-client-javascript/issues/1528))" ([#&#8203;1531](https://github.com/algolia/algoliasearch-client-javascript/issues/1531)) ([6a67e85](https://github.com/algolia/algoliasearch-client-javascript/commit/6a67e85)), closes [#&#8203;1528](https://github.com/algolia/algoliasearch-client-javascript/issues/1528) [#&#8203;1531](https://github.com/algolia/algoliasearch-client-javascript/issues/1531)
-   feat(types): add `banners` in `renderingContent` ([#&#8203;1522](https://github.com/algolia/algoliasearch-client-javascript/issues/1522)) ([5828389](https://github.com/algolia/algoliasearch-client-javascript/commit/5828389)), closes [#&#8203;1522](https://github.com/algolia/algoliasearch-client-javascript/issues/1522)
-   feat(types): add hide in renderingContent facet values ([#&#8203;1529](https://github.com/algolia/algoliasearch-client-javascript/issues/1529)) ([ed320a8](https://github.com/algolia/algoliasearch-client-javascript/commit/ed320a8)), closes [#&#8203;1529](https://github.com/algolia/algoliasearch-client-javascript/issues/1529)
-   feat(types): add missing virtual attribute to Index type ([#&#8203;1530](https://github.com/algolia/algoliasearch-client-javascript/issues/1530)) ([ba2d858](https://github.com/algolia/algoliasearch-client-javascript/commit/ba2d858)), closes [#&#8203;1530](https://github.com/algolia/algoliasearch-client-javascript/issues/1530)
-   fix(support): redirect to ticket link ([#&#8203;1527](https://github.com/algolia/algoliasearch-client-javascript/issues/1527)) ([f73a86a](https://github.com/algolia/algoliasearch-client-javascript/commit/f73a86a)), closes [#&#8203;1527](https://github.com/algolia/algoliasearch-client-javascript/issues/1527)

### [`v4.23.3`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.23.3)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.23.2...4.23.3)

-   fix(types): add `serverTimeMS` to search response ([#&#8203;1518](https://github.com/algolia/algoliasearch-client-javascript/issues/1518)) ([a1d1707](https://github.com/algolia/algoliasearch-client-javascript/commit/a1d1707)), closes [#&#8203;1518](https://github.com/algolia/algoliasearch-client-javascript/issues/1518)

### [`v4.23.2`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.23.2)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.23.1...4.23.2)

-   fix(recommend): only export default function ([#&#8203;1514](https://github.com/algolia/algoliasearch-client-javascript/issues/1514)) ([4a04d8e](https://github.com/algolia/algoliasearch-client-javascript/commits/4a04d8e)), closes [#&#8203;1514](https://github.com/algolia/algoliasearch-client-javascript/issues/1514)

### [`v4.23.1`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.23.1)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.23.0...4.23.1)

-   fix(recommend): export recommend methods to use them in algoliasearch ([#&#8203;1512](https://github.com/algolia/algoliasearch-client-javascript/issues/1512)) ([5fc5f4f](http://algolia/algoliasearch-client-javascript/commits/5fc5f4f)), closes [#&#8203;1512](http://algolia/algoliasearch-client-javascript/issues/1512)

### [`v4.23.0`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.23.0)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.22.1...4.23.0)

-   feat(search): fetch recommendations directly from algoliasearch ([#&#8203;1509](https://github.com/algolia/algoliasearch-client-javascript/issues/1509)) ([8087b28](https://github.com/algolia/algoliasearch-client-javascript/commits/8087b28)), closes [#&#8203;1509](https://github.com/algolia/algoliasearch-client-javascript/issues/1509)

### [`v4.22.1`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.22.1)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.22.0...4.22.1)

-   fix(recommend): update recommended-for-you model type ([#&#8203;1500](https://github.com/algolia/algoliasearch-client-javascript/issues/1500)) ([f94ce64](https://github.com/algolia/algoliasearch-client-javascript/commit/f94ce64)), closes [#&#8203;1500](https://github.com/algolia/algoliasearch-client-javascript/issues/1500)

### [`v4.22.0`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.22.0)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.21.1...4.22.0)

-   fix(recommend): update TrendingFacetHit facetValue type to string ([#&#8203;1498](https://github.com/algolia/algoliasearch-client-javascript/issues/1498)) ([ac9d6e2](https://github.com/algolia/algoliasearch-client-javascript/commit/ac9d6e2)), closes [#&#8203;1498](https://github.com/algolia/algoliasearch-client-javascript/issues/1498)

#### Why

The `trending-facets` API only returns type `string` for `facetValue`.

A follow-up on [#&#8203;1494](https://github.com/algolia/algoliasearch-client-javascript/issues/1494) as other models return items/hits which are of type `RecordWithObjectID`

However, `trending-facets` model returns a list of TrendingFacetHit which (by definition) don't have an `objectID` property.

#### How

To simplify the code, we can remove the type argument `TObject` for `trending-facets`

#### Impact

If you're not using TypeScript or the `trending-facets` model, there is nothing to change. You can ignore the following.

Otherwise, you will need to remove the type argument passed to `getTrendingFacets` and the code goes from this:

```tsx
type FacetType = {
  facetName: string;
  facetValue: string;
}
const { results } = await client.getTrendingFacets<FacetType>(/**/)
```

To this:

```tsx
const { results } = await client.getTrendingFacets(/**/)
```

### [`v4.21.1`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.21.1)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.21.0...4.21.1)

-   fix(recommend): RecommendedForYouQuery userToken should be required ([#&#8203;1496](https://github.com/algolia/algoliasearch-client-javascript/issues/1496)) ([d20b253](https://github.com/algolia/algoliasearch-client-javascript/commit/d20b253)), closes [#&#8203;1496](https://github.com/algolia/algoliasearch-client-javascript/issues/1496)

### [`v4.21.0`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.21.0)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.20.0...4.21.0)

-   feat(recommend): add recommended-for-you model ([#&#8203;1490](https://github.com/algolia/algoliasearch-client-javascript/issues/1490)) ([004f033](https://github.com/algolia/algoliasearch-client-javascript/commit/004f033)), closes [#&#8203;1490](https://github.com/algolia/algoliasearch-client-javascript/issues/1490)
-   fix(recommend): getTrendingFacets typing ([#&#8203;1494](https://github.com/algolia/algoliasearch-client-javascript/issues/1494)) ([94b46b5](https://github.com/algolia/algoliasearch-client-javascript/commit/94b46b5)), closes [#&#8203;1494](https://github.com/algolia/algoliasearch-client-javascript/issues/1494)
-   docs(readme): fix typo ([#&#8203;1486](https://github.com/algolia/algoliasearch-client-javascript/issues/1486)) ([db9953c](https://github.com/algolia/algoliasearch-client-javascript/commit/db9953c)), closes [#&#8203;1486](https://github.com/algolia/algoliasearch-client-javascript/issues/1486)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on the first day of the month" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 12de7d570926de5fe38eb8d81d383c5d9d528399
convex-copybara bot pushed a commit to get-convex/convex-docs that referenced this pull request Jan 29, 2025
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [algoliasearch](https://github.com/algolia/algoliasearch-client-javascript/packages/algoliasearch#readme) ([source](https://github.com/algolia/algoliasearch-client-javascript)) | dependencies | minor | [`~4.20.0` -> `~4.24.0`](https://renovatebot.com/diffs/npm/algoliasearch/4.20.0/4.24.0) |

---

### Release Notes

<details>
<summary>algolia/algoliasearch-client-javascript (algoliasearch)</summary>

### [`v4.24.0`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.24.0)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.23.3...4.24.0)

-   chore: release v4.24.0 ([#&#8203;1528](https://github.com/algolia/algoliasearch-client-javascript/issues/1528)) ([9f8956c](https://github.com/algolia/algoliasearch-client-javascript/commit/9f8956c)), closes [#&#8203;1528](https://github.com/algolia/algoliasearch-client-javascript/issues/1528)
-   chore: revert "chore: release v4.24.0 ([#&#8203;1528](https://github.com/algolia/algoliasearch-client-javascript/issues/1528))" ([#&#8203;1531](https://github.com/algolia/algoliasearch-client-javascript/issues/1531)) ([6a67e85](https://github.com/algolia/algoliasearch-client-javascript/commit/6a67e85)), closes [#&#8203;1528](https://github.com/algolia/algoliasearch-client-javascript/issues/1528) [#&#8203;1531](https://github.com/algolia/algoliasearch-client-javascript/issues/1531)
-   feat(types): add `banners` in `renderingContent` ([#&#8203;1522](https://github.com/algolia/algoliasearch-client-javascript/issues/1522)) ([5828389](https://github.com/algolia/algoliasearch-client-javascript/commit/5828389)), closes [#&#8203;1522](https://github.com/algolia/algoliasearch-client-javascript/issues/1522)
-   feat(types): add hide in renderingContent facet values ([#&#8203;1529](https://github.com/algolia/algoliasearch-client-javascript/issues/1529)) ([ed320a8](https://github.com/algolia/algoliasearch-client-javascript/commit/ed320a8)), closes [#&#8203;1529](https://github.com/algolia/algoliasearch-client-javascript/issues/1529)
-   feat(types): add missing virtual attribute to Index type ([#&#8203;1530](https://github.com/algolia/algoliasearch-client-javascript/issues/1530)) ([ba2d858](https://github.com/algolia/algoliasearch-client-javascript/commit/ba2d858)), closes [#&#8203;1530](https://github.com/algolia/algoliasearch-client-javascript/issues/1530)
-   fix(support): redirect to ticket link ([#&#8203;1527](https://github.com/algolia/algoliasearch-client-javascript/issues/1527)) ([f73a86a](https://github.com/algolia/algoliasearch-client-javascript/commit/f73a86a)), closes [#&#8203;1527](https://github.com/algolia/algoliasearch-client-javascript/issues/1527)

### [`v4.23.3`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.23.3)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.23.2...4.23.3)

-   fix(types): add `serverTimeMS` to search response ([#&#8203;1518](https://github.com/algolia/algoliasearch-client-javascript/issues/1518)) ([a1d1707](https://github.com/algolia/algoliasearch-client-javascript/commit/a1d1707)), closes [#&#8203;1518](https://github.com/algolia/algoliasearch-client-javascript/issues/1518)

### [`v4.23.2`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.23.2)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.23.1...4.23.2)

-   fix(recommend): only export default function ([#&#8203;1514](https://github.com/algolia/algoliasearch-client-javascript/issues/1514)) ([4a04d8e](https://github.com/algolia/algoliasearch-client-javascript/commits/4a04d8e)), closes [#&#8203;1514](https://github.com/algolia/algoliasearch-client-javascript/issues/1514)

### [`v4.23.1`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.23.1)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.23.0...4.23.1)

-   fix(recommend): export recommend methods to use them in algoliasearch ([#&#8203;1512](https://github.com/algolia/algoliasearch-client-javascript/issues/1512)) ([5fc5f4f](http://algolia/algoliasearch-client-javascript/commits/5fc5f4f)), closes [#&#8203;1512](http://algolia/algoliasearch-client-javascript/issues/1512)

### [`v4.23.0`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.23.0)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.22.1...4.23.0)

-   feat(search): fetch recommendations directly from algoliasearch ([#&#8203;1509](https://github.com/algolia/algoliasearch-client-javascript/issues/1509)) ([8087b28](https://github.com/algolia/algoliasearch-client-javascript/commits/8087b28)), closes [#&#8203;1509](https://github.com/algolia/algoliasearch-client-javascript/issues/1509)

### [`v4.22.1`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.22.1)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.22.0...4.22.1)

-   fix(recommend): update recommended-for-you model type ([#&#8203;1500](https://github.com/algolia/algoliasearch-client-javascript/issues/1500)) ([f94ce64](https://github.com/algolia/algoliasearch-client-javascript/commit/f94ce64)), closes [#&#8203;1500](https://github.com/algolia/algoliasearch-client-javascript/issues/1500)

### [`v4.22.0`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.22.0)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.21.1...4.22.0)

-   fix(recommend): update TrendingFacetHit facetValue type to string ([#&#8203;1498](https://github.com/algolia/algoliasearch-client-javascript/issues/1498)) ([ac9d6e2](https://github.com/algolia/algoliasearch-client-javascript/commit/ac9d6e2)), closes [#&#8203;1498](https://github.com/algolia/algoliasearch-client-javascript/issues/1498)

#### Why

The `trending-facets` API only returns type `string` for `facetValue`.

A follow-up on [#&#8203;1494](https://github.com/algolia/algoliasearch-client-javascript/issues/1494) as other models return items/hits which are of type `RecordWithObjectID`

However, `trending-facets` model returns a list of TrendingFacetHit which (by definition) don't have an `objectID` property.

#### How

To simplify the code, we can remove the type argument `TObject` for `trending-facets`

#### Impact

If you're not using TypeScript or the `trending-facets` model, there is nothing to change. You can ignore the following.

Otherwise, you will need to remove the type argument passed to `getTrendingFacets` and the code goes from this:

```tsx
type FacetType = {
  facetName: string;
  facetValue: string;
}
const { results } = await client.getTrendingFacets<FacetType>(/**/)
```

To this:

```tsx
const { results } = await client.getTrendingFacets(/**/)
```

### [`v4.21.1`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.21.1)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.21.0...4.21.1)

-   fix(recommend): RecommendedForYouQuery userToken should be required ([#&#8203;1496](https://github.com/algolia/algoliasearch-client-javascript/issues/1496)) ([d20b253](https://github.com/algolia/algoliasearch-client-javascript/commit/d20b253)), closes [#&#8203;1496](https://github.com/algolia/algoliasearch-client-javascript/issues/1496)

### [`v4.21.0`](https://github.com/algolia/algoliasearch-client-javascript/releases/tag/4.21.0)

[Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.20.0...4.21.0)

-   feat(recommend): add recommended-for-you model ([#&#8203;1490](https://github.com/algolia/algoliasearch-client-javascript/issues/1490)) ([004f033](https://github.com/algolia/algoliasearch-client-javascript/commit/004f033)), closes [#&#8203;1490](https://github.com/algolia/algoliasearch-client-javascript/issues/1490)
-   fix(recommend): getTrendingFacets typing ([#&#8203;1494](https://github.com/algolia/algoliasearch-client-javascript/issues/1494)) ([94b46b5](https://github.com/algolia/algoliasearch-client-javascript/commit/94b46b5)), closes [#&#8203;1494](https://github.com/algolia/algoliasearch-client-javascript/issues/1494)
-   docs(readme): fix typo ([#&#8203;1486](https://github.com/algolia/algoliasearch-client-javascript/issues/1486)) ([db9953c](https://github.com/algolia/algoliasearch-client-javascript/commit/db9953c)), closes [#&#8203;1486](https://github.com/algolia/algoliasearch-client-javascript/issues/1486)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on the first day of the month" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 12de7d570926de5fe38eb8d81d383c5d9d528399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

methods[key] is not a function in 4.23.0
2 participants