Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to MultiGzDecoder #560

Merged
merged 3 commits into from
Nov 26, 2022
Merged

Switch to MultiGzDecoder #560

merged 3 commits into from
Nov 26, 2022

Conversation

jsha
Copy link
Collaborator

@jsha jsha commented Nov 26, 2022

This is more correct, since all gzip streams can consist of multiple members. It has the happy side effect that it causes gzipped responses to reliably return their streams to the pool.

Small fix for #549. Uses @algesten's nice unittest from #550.

algesten and others added 2 commits October 18, 2022 21:27
This is more correct, since all gzip streams can consist of multiple members. It
has the happy side effect that it causes gzipped responses to reliably return
their streams to the pool.
@jsha
Copy link
Collaborator Author

jsha commented Nov 26, 2022

Broken lints are fixed in #561

Copy link
Owner

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're saying MultiGz is more correct?

@jsha
Copy link
Collaborator Author

jsha commented Nov 26, 2022

Yep! There's an old issue in the flate2 crate saying the same thing, with agreement from a maintainer:

rust-lang/flate2-rs#178

@jsha jsha merged commit dc7a8c3 into algesten:main Nov 26, 2022
@jsha jsha deleted the multigzdecoder branch November 26, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants