Propagate :verbose to forall macro #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the lint error is fixed in #106. |
alfert
reviewed
Apr 29, 2019
|
I really don't like the process environment, but this seems to be a reasonable solution. At least, I have not better idea. So please do a rebase and after that I will merge this PR. And after that I will make new release. |
This is a follow-up to alfert#48. When using assertions, :verbose must be set to see the actual output if an assertion fails. Alas, a user must actually used :verbose twice, once for the forall macro, and once for a property if forall is used within that macro. Example: property "failing", [:verbose] do forall n <- nat(), [:verbose] do assert n <= 0 end end This is currently necessary as we cannot share state between the two macros. This changeset rectifies that by making the options to the property available to the forall macro. The approach chosen here is to use the process dictionary. This is not as functionally clean as one might want, but it is a simple way to achieve that :verbose is only needed once in the example above: property "failing", [:verbose] do forall n <- nat() do assert n <= 0 end end
evnu
force-pushed
the
propagate-verbose-to-forall
branch
from
9c205d3
to
32320e9
Compare
|
Rebased. |
Closed
|
Thanks! I think it might be time for a new release, what do you think? |
Yes, this will happen today or tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #48.
When using assertions, :verbose must be set to see the actual output if
an assertion fails. Alas, a user must actually used :verbose twice, once
for the forall macro, and once for a property if forall is used within
that macro. Example:
This is currently necessary as we cannot share state between the two
macros. This changeset rectifies that by making the options to the
property available to the forall macro. The approach chosen here is to
use the process dictionary. This is not as functionally clean as one
might want, but it is a simple way to achieve that :verbose is only
needed once in the example above: