Skip to content

Commit

Permalink
removed promise and deferred
Browse files Browse the repository at this point in the history
  • Loading branch information
Lars-Erik Roald committed Feb 4, 2025
1 parent de43343 commit c89d99e
Show file tree
Hide file tree
Showing 20 changed files with 73 additions and 91 deletions.
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,11 @@
"@types/tedious": "^4.0.14",
"ajv": "^6.10.2",
"axios": "^1.6.2",
"deferred": "^0.7.5",
"fast-json-patch": "^3.1.1",
"findup-sync": "^5.0.0",
"glob": "^10.3.4",
"module-definition": "^4.0.0",
"node-cls": "^1.0.5",
"promise": "^8.0.3",
"rfdc": "^1.2.0",
"uuid": "^8.3.2",
"wrangler": "^3.107.2"
Expand Down Expand Up @@ -100,6 +98,9 @@
},
"tedious": {
"optional": true
},
"oracledb": {
"optional": true
}
},
"devDependencies": {
Expand Down
7 changes: 1 addition & 6 deletions src/d1/newDatabase.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ let _begin = require('../table/begin');
let commit = require('../table/commit');
let rollback = require('../table/rollback');
let newPool = require('./newPool');
let useHook = require('../useHook');
let promise = require('promise/domains');
let express = require('../hostExpress');
let hostLocal = require('../hostLocal');
let doQuery = require('../query');
Expand Down Expand Up @@ -55,10 +53,7 @@ function newDatabase(d1Database, poolOptions) {
function run() {
let p;
let transaction = newTransaction(domain, pool, options);
if (useHook())
p = new Promise(transaction);
else
p = new promise(transaction);
p = new Promise(transaction);

return p.then(begin);
}
Expand Down
12 changes: 6 additions & 6 deletions src/d1/newPool.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
var pools = require('../pools');
var promise = require('../table/promise');
var end = require('./pool/end');
var newGenericPool = require('./pool/newGenericPool');
var newId = require('../newId');
const promisify = require('node:util').promisify;
const pools = require('../pools');
const end = require('./pool/end');
const newGenericPool = require('./pool/newGenericPool');
const newId = require('../newId');

function newPool(d1Database, poolOptions) {
var pool = newGenericPool(d1Database, poolOptions);
Expand All @@ -11,7 +11,7 @@ function newPool(d1Database, poolOptions) {
var c = {};

c.connect = pool.connect;
c.end = promise.denodeify(boundEnd);
c.end = promisify(boundEnd);
pools[id] = c;
return c;
}
Expand Down
3 changes: 1 addition & 2 deletions src/mssql/newDatabase.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ let _begin = require('../table/begin');
let commit = require('../table/commit');
let rollback = require('../table/rollback');
let newPool = require('./newPool');
let promise = require('promise/domains');
let express = require('../hostExpress');
let hostLocal = require('../hostLocal');
let doQuery = require('../query');
Expand Down Expand Up @@ -53,7 +52,7 @@ function newDatabase(connectionString, poolOptions) {
function run() {
let p;
let transaction = newTransaction(domain, pool, options);
p = new promise(transaction);
p = new Promise(transaction);

return p.then(begin);
}
Expand Down
4 changes: 2 additions & 2 deletions src/mssql/newPool.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const promisify = require('node:util').promisify;
var pools = require('../pools');
var promise = require('../table/promise');
var end = require('./pool/end');
var newGenericPool = require('./pool/newGenericPool');
var newId = require('../newId');
Expand All @@ -11,7 +11,7 @@ function newPool(connectionString, poolOptions) {
var c = {};

c.connect = pool.connect;
c.end = promise.denodeify(boundEnd);
c.end = promisify(boundEnd);
pools[id] = c;
return c;
}
Expand Down
3 changes: 1 addition & 2 deletions src/mySql/newDatabase.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ let _begin = require('../table/begin');
let commit = require('../table/commit');
let rollback = require('../table/rollback');
let newPool = require('./newPool');
let promise = require('promise/domains');
let express = require('../hostExpress');
let hostLocal = require('../hostLocal');
let doQuery = require('../query');
Expand Down Expand Up @@ -53,7 +52,7 @@ function newDatabase(connectionString, poolOptions) {
function run() {
let p;
let transaction = newTransaction(domain, pool, options);
p = new promise(transaction);
p = new Promise(transaction);

return p.then(begin);
}
Expand Down
20 changes: 10 additions & 10 deletions src/mySql/newPool.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
var pools = require('../pools');
var promise = require('../table/promise');
var end = require('./pool/end');
var newGenericPool = require('./pool/newGenericPool');
var newId = require('../newId');
const promisify = require('node:util').promisify;
const pools = require('../pools');
const end = require('./pool/end');
const newGenericPool = require('./pool/newGenericPool');
const newId = require('../newId');

function newPool(connectionString, poolOptions) {
var pool = newGenericPool(connectionString, poolOptions);
var id = newId();
var boundEnd = end.bind(null, pool, id);
var c = {};
let pool = newGenericPool(connectionString, poolOptions);
let id = newId();
let boundEnd = end.bind(null, pool, id);
let c = {};

c.connect = pool.connect;
c.end = promise.denodeify(boundEnd);
c.end = promisify(boundEnd);
pools[id] = c;
return c;
}
Expand Down
3 changes: 1 addition & 2 deletions src/oracle/newDatabase.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ let _begin = require('../table/begin');
let commit = require('../table/commit');
let rollback = require('../table/rollback');
let newPool = require('./newPool');
let promise = require('promise/domains');
let express = require('../hostExpress');
let hostLocal = require('../hostLocal');
let doQuery = require('../query');
Expand Down Expand Up @@ -55,7 +54,7 @@ function newDatabase(connectionString, poolOptions) {
function run() {
let p;
let transaction = newTransaction(domain, pool, options);
p = new promise(transaction);
p = new Promise(transaction);

return p.then(begin);
}
Expand Down
20 changes: 10 additions & 10 deletions src/oracle/newPool.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
var pools = require('../pools');
var promise = require('../table/promise');
var end = require('./pool/end');
var newGenericPool = require('./pool/newGenericPool');
var newId = require('../newId');
const promisify = require('node:util').promisify;
const pools = require('../pools');
const end = require('./pool/end');
const newGenericPool = require('./pool/newGenericPool');
const newId = require('../newId');

function newPool(connectionString, poolOptions) {
var pool = newGenericPool(connectionString, poolOptions);
var id = newId();
var boundEnd = end.bind(null, pool, id);
var c = {};
let pool = newGenericPool(connectionString, poolOptions);
let id = newId();
let boundEnd = end.bind(null, pool, id);
let c = {};

c.connect = pool.connect;
c.end = promise.denodeify(boundEnd);
c.end = promisify(boundEnd);
pools[id] = c;
return c;
}
Expand Down
3 changes: 1 addition & 2 deletions src/pg/newDatabase.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ let rollback = require('../table/rollback');
let newPool = require('./newPool');
let lock = require('../lock');
let executeSchema = require('./schema');
let promise = require('promise/domains');
let express = require('../hostExpress');
let hostLocal = require('../hostLocal');
let doQuery = require('../query');
Expand Down Expand Up @@ -61,7 +60,7 @@ function newDatabase(connectionString, poolOptions) {
function run() {
let p;
let transaction = newTransaction(domain, pool, options);
p = new promise(transaction);
p = new Promise(transaction);

return p.then(begin)
.then(negotiateSchema);
Expand Down
20 changes: 10 additions & 10 deletions src/pg/newPool.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
var pools = require('../pools');
var promise = require('../table/promise');
var end = require('./pool/end');
var newPgPool = require('./pool/newPgPool');
var newId = require('../newId');
const promisify = require('node:util').promisify;
const pools = require('../pools');
const end = require('./pool/end');
const newPgPool = require('./pool/newPgPool');
const newId = require('../newId');

function newPool(connectionString, poolOptions) {
var pool = newPgPool(connectionString, poolOptions);
var id = newId();
var boundEnd = end.bind(null, pool, id);
var c = {};
let pool = newPgPool(connectionString, poolOptions);
let id = newId();
let boundEnd = end.bind(null, pool, id);
let c = {};

c.connect = pool.connect;
c.end = promise.denodeify(boundEnd);
c.end = promisify(boundEnd);
pools[id] = c;
return c;
}
Expand Down
3 changes: 1 addition & 2 deletions src/sap/newDatabase.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ let _begin = require('../table/begin');
let commit = require('../table/commit');
let rollback = require('../table/rollback');
let newPool = require('./newPool');
let promise = require('promise/domains');
let express = require('../hostExpress');
let hostLocal = require('../hostLocal');
let doQuery = require('../query');
Expand Down Expand Up @@ -55,7 +54,7 @@ function newDatabase(connectionString, poolOptions) {
function run() {
let p;
let transaction = newTransaction(domain, pool, options);
p = new promise(transaction);
p = new Promise(transaction);

return p.then(begin);
}
Expand Down
4 changes: 2 additions & 2 deletions src/sap/newPool.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const promisify = require('node:util').promisify;
var pools = require('../pools');
var promise = require('../table/promise');
var end = require('./pool/end');
var newGenericPool = require('../mssql/pool/newGenericPool');
var newId = require('../newId');
Expand All @@ -11,7 +11,7 @@ function newPool(connectionString, poolOptions) {
var c = {};

c.connect = pool.connect;
c.end = promise.denodeify(boundEnd);
c.end = promisify(boundEnd);
pools[id] = c;
return c;
}
Expand Down
3 changes: 1 addition & 2 deletions src/sqlite/newDatabase.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ let _begin = require('../table/begin');
let commit = require('../table/commit');
let rollback = require('../table/rollback');
let newPool = require('./newPool');
let promise = require('promise/domains');
let express = require('../hostExpress');
let hostLocal = require('../hostLocal');
let doQuery = require('../query');
Expand Down Expand Up @@ -53,7 +52,7 @@ function newDatabase(connectionString, poolOptions) {
function run() {
let p;
let transaction = newTransaction(domain, pool, options);
p = new promise(transaction);
p = new Promise(transaction);

return p.then(begin);
}
Expand Down
20 changes: 10 additions & 10 deletions src/sqlite/newPool.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
var pools = require('../pools');
var promise = require('../table/promise');
var end = require('./pool/end');
var newGenericPool = require('./pool/newGenericPool');
var newId = require('../newId');
const promisify = require('node:util').promisify;
const pools = require('../pools');
const end = require('./pool/end');
const newGenericPool = require('./pool/newGenericPool');
const newId = require('../newId');

function newPool(connectionString, poolOptions) {
var pool = newGenericPool(connectionString, poolOptions);
var id = newId();
var boundEnd = end.bind(null, pool, id);
var c = {};
let pool = newGenericPool(connectionString, poolOptions);
let id = newId();
let boundEnd = end.bind(null, pool, id);
let c = {};

c.connect = pool.connect;
c.end = promise.denodeify(boundEnd);
c.end = promisify(boundEnd);
pools[id] = c;
return c;
}
Expand Down
7 changes: 1 addition & 6 deletions src/table/promise.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,8 @@
var promise = require('promise/domains');
let promisify = require('util').promisify;

function newPromise(func) {
if (!func)
return Promise.resolve.apply(Promise, arguments);
// return deferred.resolve.apply(deferred, arguments);
return new promise(func);
return new Promise(func);
}

newPromise.all = Promise.all;
newPromise.denodeify = promisify || promise.denodeify;
module.exports = newPromise;
3 changes: 1 addition & 2 deletions src/table/rowArray/negotiateNextTick.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
var promise = require('promise/domains');

function negotiateNextTick(i) {
if (i === 0)
return;
if (i % 1000 === 0)
return promise.resolve();
return Promise.resolve();
return;
}

Expand Down
3 changes: 1 addition & 2 deletions src/tedious/newDatabase.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ let _begin = require('../table/begin');
let commit = require('../table/commit');
let rollback = require('../table/rollback');
let newPool = require('./newPool');
let promise = require('promise/domains');
let express = require('../hostExpress');
let hostLocal = require('../hostLocal');
let doQuery = require('../query');
Expand Down Expand Up @@ -54,7 +53,7 @@ function newDatabase(connectionString, poolOptions) {
function run() {
let p;
let transaction = newTransaction(domain, pool, options);
p = new promise(transaction);
p = new Promise(transaction);

return p.then(begin);
}
Expand Down
20 changes: 10 additions & 10 deletions src/tedious/newPool.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
var pools = require('../pools');
var promise = require('../table/promise');
var end = require('./pool/end');
var newGenericPool = require('./pool/newGenericPool');
var newId = require('../newId');
const promisify = require('node:util').promisify;
const pools = require('../pools');
const end = require('./pool/end');
const newGenericPool = require('./pool/newGenericPool');
const newId = require('../newId');

function newPool(connectionString, poolOptions) {
var pool = newGenericPool(connectionString, poolOptions);
var id = newId();
var boundEnd = end.bind(null, pool, id);
var c = {};
let pool = newGenericPool(connectionString, poolOptions);
let id = newId();
let boundEnd = end.bind(null, pool, id);
let c = {};

c.connect = pool.connect;
c.end = promise.denodeify(boundEnd);
c.end = promisify(boundEnd);
pools[id] = c;
return c;
}
Expand Down
1 change: 0 additions & 1 deletion tests/d1.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ describe('Cloudflare D1 Database Tests', () => {
const result = await d1.prepare('SELECT * FROM my_table WHERE name = ?')
.bind('test')
.all();
console.dir(result);

expect(result.results[0].name).toBe('test');
expect(result.results[0].value).toBe(123);
Expand Down

0 comments on commit c89d99e

Please sign in to comment.