Repository navigation
hash: resolve a symlinked root before walking - #23
Merged
Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A skill directory that is itself a symlink (OpenClaude follows them when loading skills) was discovered and listed, but
filepath.WalkDirdoes not follow a symlinked root: it reports the link as a non-regular entry and yields no files. The artifact landed in the lockfile with the empty digest and no file list, and an edit behind the link passedverify. The hasher now resolves the root withEvalSymlinksonce before walking; symlinks inside the tree stay skipped as before. Reproduced with 0.4.5 on a project skill symlink (empty digest, verify exit 0 after an edit); with this change the file list is populated and the edit exits 1. Found by a reviewer on the OpenClaude docs PR.