Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the problem of setImageURI behavior #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AbdallaBadreldin
Copy link

@AbdallaBadreldin AbdallaBadreldin commented Nov 11, 2024

Hello

the library is working well when we set setImageDrawable(Drawable) or just use src in xml. The problem happens when we use
setImageBitmap(Bitmap) || setImageURI(Uri) for newer SDKs

I figured out that when developer call setImageDrawable() the library start to updated Controller and dimention but for other functions the library doesn't update dimentions, invalidateDrawable(Drawable) is good for fixing this problem but it will create another issues, so I made a function and moved the bulk of code that happen in setImageDrawable() in it. it's in the same class (GestureImageView) once the developer calls any function to show a picture. This function will be invoked

thank you

Hello

the library is working well when we set setImageDrawable(Drawable) or just use src from xml
the problem happen when we use
setImageBitmap(Bitmap) || setImageURI(Uri) for newer SDKs

I figured out that when  developer call SetImageDrawable() the library start to updated Controller and dimention so but for other function the library doesn't update dimentions, invalidateDrawable(Drawable) is good for fixing this problem but it  will create another issues, soI mdae function that is common it's in the same Class (GestureImageView) once developer call any function to show a picture this this function is going to be invoked

thank you
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant