A poorly styled change #2

alextwoods · 2020-02-12T01:04:57Z

Pronto?

github-actions · 2020-02-12T01:29:24Z

test.rb

@@ -1,3 +1,7 @@
 if x = 1
  puts "This should trigger warnings!"
 end
+
+if y = 3


Useless assignment to variable - y.

github-actions · 2020-02-12T01:29:25Z

test.rb

@@ -1,3 +1,7 @@
 if x = 1
  puts "This should trigger warnings!"
 end
+
+if y = 3


Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.

github-actions · 2020-02-12T01:29:26Z

test.rb

@@ -1,3 +1,7 @@
 if x = 1
  puts "This should trigger warnings!"
 end
+
+if y = 3
+  puts "This is a new change that should get a comment"


Prefer single-quoted strings when you don't need string interpolation or special symbols.

A poorly styled change

b7ec43d

github-actions bot reviewed Feb 12, 2020

View reviewed changes

test.rb

@@ -1,3 +1,7 @@

if x = 1

puts "This should trigger warnings!"

end

if y = 3

Copy link

github-actions bot Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless assignment to variable - y.

github-actions bot reviewed Feb 12, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

A poorly styled change #2

A poorly styled change #2

alextwoods commented Feb 12, 2020

github-actions bot Feb 12, 2020

github-actions bot Feb 12, 2020

github-actions bot Feb 12, 2020

A poorly styled change #2

Are you sure you want to change the base?

A poorly styled change #2

Conversation

alextwoods commented Feb 12, 2020

github-actions bot Feb 12, 2020

Choose a reason for hiding this comment

github-actions bot Feb 12, 2020

Choose a reason for hiding this comment

github-actions bot Feb 12, 2020

Choose a reason for hiding this comment