Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sigv4 gem updates: SRA Identity + backports #48

Merged
merged 14 commits into from
May 8, 2024
Merged

Conversation

alextwoods
Copy link
Owner

@alextwoods alextwoods commented May 6, 2024

Description of changes:

Removes options for credential_providers and instead requires users to provide credentials when calling any of the signing methods. This removes the multiple different ways to configure credentials when signing and uses the interface to enforce best practices around credential refreshing.

Adds support for passing a request object (eg: a Hearth::HTTP::Request) and supports using either url or uri from the request (url takes precedence if both are provided).

Updates other parameter names (uri_escape_path and normalize_path) to match CRT names.

Backports changes from v3 sigv4 gem:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alextwoods alextwoods requested a review from mullermp May 6, 2024 21:00
gems/aws-sdk-core/lib/aws-sdk-core/signers/sigv4.rb Outdated Show resolved Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/signers/sigv4.rb Outdated Show resolved Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/signers/sigv4.rb Outdated Show resolved Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/signers/sigv4.rb Outdated Show resolved Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/signers/sigv4.rb Outdated Show resolved Hide resolved
gems/aws-sigv4/lib/aws-sigv4/signer.rb Outdated Show resolved Hide resolved
gems/aws-sigv4/spec/aws-sigv4/signer_spec.rb Show resolved Hide resolved
gems/aws-sigv4/spec/aws-sigv4/signer_spec.rb Outdated Show resolved Hide resolved
gems/aws-sigv4/spec/aws-sigv4/signer_spec.rb Outdated Show resolved Hide resolved
gems/aws-sigv4/spec/aws-sigv4/signer_spec.rb Show resolved Hide resolved
gems/aws-sigv4/lib/aws-sigv4/signer.rb Outdated Show resolved Hide resolved
@mullermp mullermp merged commit 768f137 into main May 8, 2024
10 checks passed
@mullermp mullermp deleted the sigv4_gem_updates branch May 8, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants