[server] Remove unnecessary re-borrow for connection future #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the graceful shutdown implementation, the connection future was unnecessarily re-borrowed as `&mut conn.as_mut()`, which can be simplified to `conn.as_mut()`, since the receiver of the future is expecting a `Pin<&mut ...>` type. Nits: Fixes missing #cfg directives for imports in `src/info/mod.rs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the graceful shutdown implementation, the connection future was
unnecessarily re-borrowed as
&mut conn.as_mut(), which can besimplified to
conn.as_mut(), since the receiver of the future isexpecting a
Pin<&mut ...>type.Nits: Fixes missing #cfg directives for imports in
src/info/mod.rs