-
Notifications
You must be signed in to change notification settings - Fork 6
Fix static path for global install #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR! Do you mind turning your autoformatter off and re-submitting? The actual change is a little hard to find. |
|
thanks; it's clear now. Looks like upstream has not merged the PR which should fix this: serialport/bindings-interface#32 (2) switch to |
|
Goddamn it |
|
@bedirxanugur Mind trying this version? It works for me, both |
|
Tested successfully! Built locally on Windows, deployed to Raspberry Pi, and everything’s running smoothly. Thanks for the changes! |
Thanks for your fix! === For my own curiosity, which generation RPi? Am I correctly assuming it's an older/under-powered one since you're "building" on a laptop and then copying the files over? There are lots of older performance bugs in the original repo (https://github.com/nornagon/saxi) and it's hard to tell which have been solved already. |
When saxi is installed globally via
npm install -g saxi,the web interface returns "Cannot GET /" error.
This fixes the issue by using
import.meta.urlto resolvethe static files path relative to the module location instead
of the current working directory.
Tested on Raspberry Pi with global installation.