Skip to content
This repository has been archived by the owner on Oct 25, 2018. It is now read-only.

xdg-app add-remote --gpg-import=something.gpg succeeds even when the gpg file could not be found #92

Open
murraycu opened this issue Dec 9, 2015 · 0 comments

Comments

@murraycu
Copy link
Contributor

murraycu commented Dec 9, 2015

If I forget to download the gpg key, and then do, for instance:

$ xdg-app add-remote --user --gpg-import=prefixsuffix.gpg prefixsuffix https://murraycu.github.io/prefixsuffix/repo/

I will see this error message, which could be more specific:
error: Error opening file: No such file or directory

When I then download the GPG file and try again, I see:
error: Remote configuration for "prefixsuffix" already exists: /home/murrayc/.local/share/xdg-app/repo/config

so I have to

$ xdg-app delete-remote --user prefixsuffix

and then do it again.

So I guess the error didn't really stop the add-remote operation.

I might get around to fixing this myself at some point.

murraycu added a commit to murraycu/xdg-app that referenced this issue Dec 14, 2015
It seems wise to check local files before checking remote files.
Then we can fail more quickly.
And this stops us from adding a remote repository even when the
specified gpg key could not be found:
alexlarsson#92
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant