Optional attribute to prevent small images from being stretched #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an optional attribute that prevents the result image to be stretched in case it is smaller than result-image-size.
cgaggino
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the original image's dimensions are smaller than the value of the result-image-size attribute, the cropped image will be scaled up. Sometimes this might not be the intended behaviour. I added the attribute dont-stretch-smaller-images which stops that behaviour. If the image is smaller than result-image-size then the original image size is used for the cropped image.
This pull request exposes the solution described in #78 through an optional attribute on the ng-img-crop directive.