lib: endianness of cid was changed with fix for init parsing

this caused issues on some u2f devices fixes Yubico#115
alexisfrjp · Mar 6, 2019 · 1081a0f · 1081a0f
1 parent ce9f3db
commit 1081a0f
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/u2f-host/devs.c b/u2f-host/devs.c
@@ -315,10 +315,8 @@ init_device (u2fh_devs * devs, struct u2fdevice *dev)
 	  return U2FH_TRANSPORT_ERROR;
 	}
 
-      dev->cid =
-	resp[offs] << 24 | resp[offs + 1] << 16 | resp[offs +
-						       2] << 8 | resp[offs +
-								      3];
+
+      memcpy((uint8_t*)&dev->cid, resp + offs, sizeof(dev->cid));
       offs += 4;
       dev->versionInterface = resp[offs++];
       dev->versionMajor = resp[offs++];