Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online marglik as a method #64

Merged
merged 6 commits into from
Dec 10, 2021
Merged

Online marglik as a method #64

merged 6 commits into from
Dec 10, 2021

Conversation

aleximmer
Copy link
Owner

No description provided.

@aleximmer aleximmer requested a review from runame December 9, 2021 17:51
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think my comment below regarding the Laplace interface is the only thing to discuss.

One more very minor question: any reason why you did not call the file marglik_training.py?

laplace/marglik.py Outdated Show resolved Hide resolved
laplace/marglik.py Outdated Show resolved Hide resolved
@runame
Copy link
Collaborator

runame commented Dec 9, 2021

Not sure what we decided before, but we also considered having a designated directory for methods, right? We can still add that later when we have more methods though.

laplace/marglik_training.py Outdated Show resolved Hide resolved
@runame runame merged commit 37aee4f into main Dec 10, 2021
@runame runame deleted the online-marglik branch December 10, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants