Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SubnetLaplace backend check #239

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Fix SubnetLaplace backend check #239

merged 2 commits into from
Sep 14, 2024

Conversation

wiseodd
Copy link
Collaborator

@wiseodd wiseodd commented Sep 2, 2024

Based on #232

@wiseodd wiseodd added the bug Something isn't working label Sep 2, 2024
@wiseodd wiseodd requested review from aleximmer and runame September 2, 2024 18:36
@wiseodd wiseodd self-assigned this Sep 2, 2024
@wiseodd wiseodd mentioned this pull request Sep 2, 2024
Closed
aleximmer
aleximmer approved these changes Sep 4, 2024
View reviewed changes
laplace/subnetlaplace.py Show resolved Hide resolved
tests/test_subnetlaplace.py Show resolved Hide resolved
@aleximmer
Copy link
Owner

I think you can merge unless @runame wants to have a look as well.

runame
runame approved these changes Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wiseodd wiseodd merged commit 26b1d19 into main Sep 14, 2024
4 checks passed
@wiseodd wiseodd deleted the subnet-backend branch September 14, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleximmer aleximmer aleximmer approved these changes

@runame runame runame approved these changes

Assignees

@wiseodd wiseodd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wiseodd @aleximmer @runame