Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate uv #227

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Incorporate uv #227

merged 6 commits into from
Aug 21, 2024

Conversation

wiseodd
Copy link
Collaborator

@wiseodd wiseodd commented Aug 21, 2024

Two main places:

  1. setup.cfg -> pyproject.toml
  2. pytest CI

For building and publishing, check out https://docs.astral.sh/uv/guides/publish/

@wiseodd wiseodd added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 21, 2024
@wiseodd wiseodd requested a review from runame August 21, 2024 01:33
@wiseodd wiseodd self-assigned this Aug 21, 2024
runame
runame approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@runame runame left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM.

Question: Do we still need setup.py? I think for everything besides publishing to PyPI pyproject.toml is the only file we need, but not sure about PyPI?

@wiseodd
Copy link
Collaborator Author

wiseodd commented Aug 21, 2024

Yes, setup.py is not needed anymore. I removed it.

@wiseodd wiseodd merged commit 17941f2 into main Aug 21, 2024
3 checks passed
@wiseodd wiseodd deleted the uv branch August 21, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

Assignees

@wiseodd wiseodd

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiseodd @runame