Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typehinting #180

Merged
merged 12 commits into from
Jun 15, 2024
Merged

Typehinting #180

merged 12 commits into from
Jun 15, 2024

Conversation

wiseodd
Copy link
Collaborator

@wiseodd wiseodd commented Apr 27, 2024

Closes #68

WIP and blocked by #144

@wiseodd wiseodd added the enhancement New feature or request label Apr 27, 2024
@wiseodd wiseodd added this to the 0.2 milestone Apr 27, 2024
@wiseodd wiseodd requested review from aleximmer and runame April 27, 2024 17:18
@wiseodd wiseodd self-assigned this Apr 27, 2024
@wiseodd wiseodd changed the base branch from main to mc-subset2 April 27, 2024 17:24
Base automatically changed from mc-subset2 to main April 27, 2024 18:53
@wiseodd wiseodd marked this pull request as ready for review April 28, 2024 19:30
@wiseodd
Copy link
Collaborator Author

wiseodd commented Apr 28, 2024

Ready for review!

Typehinting and then typechecking with pyright really shows that there are many ambiguous typing going on in our code. To be fair due to Python allowing it. Good idea to be strict with typing for next projects lol---lesson learned.

@wiseodd wiseodd mentioned this pull request Jun 8, 2024
Merged
@wiseodd
Copy link
Collaborator Author

wiseodd commented Jun 13, 2024

@runame ready for review!

runame
runame approved these changes Jun 15, 2024
View reviewed changes
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't carefully check every diff, but LGTM. I think this definitely improved the code quality!

laplace/curvature/asdfghjkl.py Show resolved Hide resolved
@wiseodd wiseodd merged commit 3c99a04 into main Jun 15, 2024
3 checks passed
@wiseodd wiseodd deleted the typehinting branch June 15, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runame runame runame approved these changes

@aleximmer aleximmer Awaiting requested review from aleximmer

Assignees

@wiseodd wiseodd

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2
Development

Successfully merging this pull request may close these issues.

Add support for type hints
2 participants
@wiseodd @runame