Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the dict keys for models with dict-like inputs general #168

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

wiseodd
Copy link
Collaborator

@wiseodd wiseodd commented Apr 23, 2024

Closes #165

@runame @aleximmer please wait until #144 is merged.

@wiseodd wiseodd added the enhancement New feature or request label Apr 23, 2024
@wiseodd wiseodd added this to the 0.2 milestone Apr 23, 2024
@wiseodd wiseodd requested review from aleximmer and runame April 23, 2024 20:39
@wiseodd wiseodd self-assigned this Apr 23, 2024
@wiseodd wiseodd changed the base branch from main to mc-subset2 April 27, 2024 17:27
Base automatically changed from mc-subset2 to main April 27, 2024 18:53
@wiseodd
Copy link
Collaborator Author

wiseodd commented Apr 27, 2024

Ready to review!

Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

laplace/utils/utils.py Outdated Show resolved Hide resolved
@wiseodd wiseodd merged commit fddcf55 into main Jun 10, 2024
@wiseodd wiseodd deleted the generalized-dict-input branch June 10, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalized dict-input mechanism
2 participants