Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snap #115

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Added snap #115

wants to merge 15 commits into from

Conversation

soumyaDghosh
Copy link

Completes #107

@soumyaDghosh
Copy link
Author

Hello @alexhuntley kindly check this pull

Copy link

@kenvandine kenvandine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jumping into this PR hoping to help get the snap into the store. Added a few requested changes.

snap/gui/plots.desktop Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
@alexhuntley
Copy link
Owner

I haven't submitted Plots to the Snap store because I never figured out how to correctly install the required math font for rendering the equations.

If anyone knows the correct way to do this, I'd love to hear about it. Until I figure this out, the snap package won't work correctly.

@soumyaDghosh
Copy link
Author

You can test it by installing te plots snap from snap store. This PR achieves it. Give it a shot and give me some reviews of yours on it. Thanks.

@alexhuntley
Copy link
Owner

I can't test it right now but thank you for the effort anyway. However judging from the screenshot on the Snap store, the wrong font is still being used for rendering the equations.

@soumyaDghosh
Copy link
Author

image

Is this the font you wanted?

image

@soumyaDghosh
Copy link
Author

@alexhuntley kindly look into the previous comment. I have added the font that you wanted to use.

@soumyaDghosh
Copy link
Author

@alexhuntley kindly take the snap package as an official one. I have fixed the font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants