Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream body support? #25

Closed
wmertens opened this issue Aug 22, 2021 · 5 comments
Closed

Stream body support? #25

wmertens opened this issue Aug 22, 2021 · 5 comments

Comments

@wmertens
Copy link

Hi, I'm scoping out your library :)

When looking at response.ts it seems that if the body is a stream, that's not supported, right? I'm new to got so not sure how streams work.

If that's the case, would that be solved by using the consumeBody function from node-fetch?

@alexghr
Copy link
Owner

alexghr commented Oct 28, 2021

Hey, might be too late for your use case by now but I'll have a look and see if I can add stream support.

@alexghr alexghr self-assigned this Oct 28, 2021
alexghr added a commit that referenced this issue Apr 10, 2022
* feat: add support for response streams

* ci: enable AbortController on Node 14

* feat: support streaming request body

fix #25
github-actions bot pushed a commit that referenced this issue Apr 10, 2022
# [5.1.0-next.1](v5.0.2...v5.1.0-next.1) (2022-04-10)

### Features

* add support for response streams ([#134](#134)) ([abc1732](abc1732)), closes [#25](#25)
@github-actions
Copy link

🎉 This issue has been resolved in version 5.1.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wmertens
Copy link
Author

Awesome, thanks! :)

@alexghr
Copy link
Owner

alexghr commented Apr 10, 2022

Ha, wasn't sure if you were still interested in this after ... 7-8 months. I've published it under the next tag on npm. If you do end up trying it, could you let me know how/if it works for your use case? I've discovered a couple of issues with got's stream handling while working on this.

alexghr added a commit that referenced this issue Apr 16, 2022
* feat: add support for response streams (#134)

* feat: add support for response streams

* ci: enable AbortController on Node 14

* feat: support streaming request body

fix #25

* chore(release): 5.1.0-next.1 [skip ci]

# [5.1.0-next.1](v5.0.2...v5.1.0-next.1) (2022-04-10)

### Features

* add support for response streams ([#134](#134)) ([abc1732](abc1732)), closes [#25](#25)

Co-authored-by: semantic-release-bot <[email protected]>
alexghr added a commit that referenced this issue Apr 19, 2022
This is an empty commit in order to get semantic-release to publish the
code that was merged through a squash-and-merge action.

fix #25
github-actions bot pushed a commit that referenced this issue Apr 19, 2022
# [5.1.0](v5.0.2...v5.1.0) (2022-04-19)

### Features

* support streams ([4ef2b66](4ef2b66)), closes [#25](#25)
@github-actions
Copy link

🎉 This issue has been resolved in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants