Skip to content

Commit

Permalink
src: remove unnecessary todo
Browse files Browse the repository at this point in the history
PR-URL: nodejs#49227
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
RafaelGSS authored and alexfernandez committed Nov 1, 2023
1 parent 470c6f8 commit 9d19439
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/node_file.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2081,7 +2081,6 @@ static inline Maybe<void> CheckOpenPermissions(Environment* env,
const int write_as_side_effect = flags & (UV_FS_O_APPEND | UV_FS_O_CREAT |
UV_FS_O_TRUNC | UV_FS_O_TEMPORARY);

// TODO(rafaelgss): it can be optimized to avoid two permission checks
auto pathView = path.ToStringView();
if (rwflags != UV_FS_O_WRONLY) {
THROW_IF_INSUFFICIENT_PERMISSIONS(
Expand Down

0 comments on commit 9d19439

Please sign in to comment.