Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 127.0.0.1 with Public IP address while generating kube config #44

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Replace 127.0.0.1 with Public IP address while generating kube config #44

merged 1 commit into from
Oct 8, 2019

Conversation

gosuri
Copy link
Contributor

@gosuri gosuri commented Oct 8, 2019

Replaces 127.0.0.1 in addition to localhost
in KUBECONFIG to support k3s 0.9.0

Signed-off-by: Greg Osuri [email protected]

Description

Replaces 127.0.0.1 in addition to localhost while generating kube config

Motivation and Context

Fixes #43

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

I have tested the changes with k3s v0.8.2 and v0.9.0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gosuri
Replace 127.0.0.1 with Public IP address
498444a 
Replaces 127.0.0.1 in addition to localhost
in KUBECONFIG to support k3s 0.9.0

Signed-off-by: Greg Osuri <[email protected]>
@derek derek bot added the new-contributor label Oct 8, 2019
alexellis
alexellis approved these changes Oct 8, 2019
View reviewed changes
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 9694a6f into alexellis:master Oct 8, 2019
@alexellis
Copy link
Owner

CC @viveksyngh

@alexellis
Copy link
Owner

https://github.com/alexellis/k3sup/releases/tag/0.3.1

Thank you sir!

@gosuri
Copy link
Contributor Author

gosuri commented Oct 8, 2019

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis alexellis approved these changes

Assignees
No one assigned
Labels
new-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server address in kubeconfig is set to 127.0.0.1 for k3s 0.9.0
2 participants
@gosuri @alexellis