Make Grep case insensitive in download script #219
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github made the location header lowercase, so our get.sh script was failing. This makes the grep case insensitive. Tested by running the script to make sure it failed, then making the grep into a `grep -i` and running again, this time it worked. Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Github made the location header lowercase, so our get.sh script was
failing. This makes the grep case insensitive.
Tested by running the script to make sure it failed, then making the
grep into a
grep -iand running again, this time it worked.Motivation and Context
How Has This Been Tested?
see above
Types of changes
Checklist:
git commit -s