Re-add the --wait flag to the helm3 installation #205
Merged
+34
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit re-adds the wait flag to helm3 installation and sets the default --version to empty string, this installs the latest chart version by default. When we need a specific version we can set it (see cert-manager) Signed-off-by: Alistair Hey <alistair@heyal.co.uk>
alexellis
reviewed
Feb 20, 2020
| @@ -120,7 +121,7 @@ func MakeInstallCertManager() *cobra.Command { | |||
| return err | |||
| } | |||
| } else { | |||
| err = templateChart(chartPath, "cert-manager", namespace, outputPath, "values.yaml", "v0.12.0", nil) | |||
| err = templateChart(chartPath, "cert-manager", namespace, outputPath, "values.yaml", nil) | |||
There was a problem hiding this comment.
I think this reverted the version or pinning
There was a problem hiding this comment.
its moved into fetchChart (for helm2)
Is there any reason not to use --wait for all of the commands? |
|
Yes it's blocking and slow. Using async means you can pull images in parallel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit re-adds the wait flag to helm3 installation
and sets the default --version to empty string, this
installs the latest chart version by default. When we need
a specific version we can set it (see cert-manager)
This was removed in a previous commit was it was not being used
but it should be used. It provides a better UX, as apps are ready once
k3sup returns. Otherwise when chaining installs like cert-manager and
openfaas ingress (which relies on the cert-manager installation being ready)
we an get errors.
I have also added a const to represent default chart version rather then using the
empty string.
Motivation and Context
Reverting a removed feature and enabling it
How Has This Been Tested?
Installed a chart with version (cert-manager) with helm2 & helm3, validated
that the install was successful and the correct version was installed
Types of changes
Checklist:
git commit -s