Only print out stderr with --local if there's a non-zero exit

Optimisation for running k3sup in CI

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>

cmd/install.go

@@ -266,9 +266,12 @@ Provide the --local-path flag with --merge if a kubeconfig already exists in som
 					return err
 				}
 
-				if len(res.StdErr) > 0 {
-					fmt.Printf("stderr: %q", res.StdErr)
+				if res.ExitCode != 0 {
+					if len(res.StdErr) > 0 {
+						fmt.Printf("stderr: %q", res.StdErr)
+					}
 				}
+
 				if len(res.StdOut) > 0 {
 					fmt.Printf("stdout: %q", res.StdOut)
 				}

pkg/operator/exec_operator.go

@@ -21,8 +21,9 @@ func (ex ExecOperator) ExecuteStdio(command string, stream bool) (CommandRes, er
 	}
 
 	return CommandRes{
-		StdErr: []byte(res.Stderr),
-		StdOut: []byte(res.Stdout),
+		StdErr:   []byte(res.Stderr),
+		StdOut:   []byte(res.Stdout),
+		ExitCode: res.ExitCode,
 	}, nil
 }
 

pkg/operator/operator.go

@@ -8,6 +8,7 @@ type CommandOperator interface {
 
 // CommandRes contains the STDIO output from running a command
 type CommandRes struct {
-	StdOut []byte
-	StdErr []byte
+	StdOut   []byte
+	StdErr   []byte
+	ExitCode int
 }