fix: Issue when sharing request that isn't json

alexbrazier · Jul 27, 2020 · 202c31d · 202c31d
1 parent 06e557b
commit 202c31d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/example/src/App.tsx b/example/src/App.tsx
@@ -18,6 +18,8 @@ export default function App() {
     fetch('https://httpstat.us/302');
     fetch('https://httpstat.us/400');
     fetch('https://httpstat.us/500');
+    // Non JSON response
+    fetch('https://postman-echo.com/stream/2');
     // Test requests that fail
     // fetch('https://failingrequest');
   };

diff --git a/src/components/RequestDetails.tsx b/src/components/RequestDetails.tsx
@@ -89,9 +89,17 @@ const RequestDetails: React.FC<Props> = ({ request, onClose }) => {
   const requestBody = request.getRequestBody();
 
   const getFullRequest = () => {
+    let response;
+    if (responseBody) {
+      try {
+        response = JSON.parse(responseBody);
+      } catch {
+        response = `${responseBody}`;
+      }
+    }
     const processedRequest = {
       ...request,
-      response: responseBody ? JSON.parse(responseBody) : undefined,
+      response,
       duration: request.duration,
     };
     return JSON.stringify(processedRequest, null, 2);