Skip to content

fix(ci): drop track_progress where the event has no issue/PR context - #2909

Merged
alexbelgium merged 1 commit into
masterfrom
fix/ci-track-progress-dispatch
Jul 27, 2026
Merged

alexbelgium merged 1 commit into
masterfrom
fix/ci-track-progress-dispatch

Conversation

@alexbelgium

@alexbelgium alexbelgium commented Jul 27, 2026 •

Copy link
Copy Markdown
Owner

What broke

The AI fix sweep has never completed a non-empty batch. Run 30265277395 failed in Analyse and fix after ~0.3s, before any analysis happened:

##[error]Action failed with error: track_progress is only supported for events:
pull_request, issues, issue_comment, pull_request_review_comment, pull_request_review.
Current event: workflow_dispatch
##[error]Process completed with exit code 1.

track_progress needs an issue or PR to hang its sticky comment on. daily_ai_fix.yaml triggers only on schedule and workflow_dispatch, neither of which has one, so claude-code-action rejects the input during validation.

Why nobody noticed

The step is gated on if: steps.batch.outputs.count != '0'. Runs with an empty batch skip it entirely and report green:

run event Analyse and fix
30265277395 workflow_dispatch failure
30236697655 schedule skipped
30072643898 workflow_dispatch skipped
30011599875 workflow_dispatch failure

Every green run is a no-op. Every run with issues to work through failed the same way. The 3am cron would fail identically the moment an ai-triage issue exists — this is not dispatch-only.

Changes

  • daily_ai_fix.yaml — remove track_progress. No trigger of this workflow can satisfy the constraint, so there is no conditional worth keeping. Per-issue reporting is unaffected: issue-fix.md already has Claude comment on each issue via gh. Only the run-level sticky comment is lost.
  • on_issue_approved.yaml — same latent failure on its workflow_dispatch path, but its issues path is valid, so gate on the event rather than dropping it: track_progress: ${{ github.event_name == 'issues' }}. The action declares this input's default as the string "false", so the expression result is a shape it already handles.

Verification

Both files parse. Not runtime-verified — that needs a dispatch with a non-empty ai-triage batch, which is worth doing once this lands.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved automated issue and pull request processing by preventing unsupported progress tracking in batch workflows.
    • Progress tracking is now enabled only when a suitable issue conversation is available, preventing failures during manually triggered workflows.
    • Clarified progress reporting behavior for automated fixes.

The AI fix sweep has never completed a non-empty batch. claude-code-action
rejects track_progress unless the triggering event is pull_request, issues,
issue_comment, pull_request_review_comment or pull_request_review, and
daily_ai_fix.yaml only ever runs on schedule or workflow_dispatch. The step
died in input validation after 0.3s:

  Action failed with error: track_progress is only supported for events:
  pull_request, issues, issue_comment, pull_request_review_comment,
  pull_request_review. Current event: workflow_dispatch

This went unnoticed because the step is gated on `count != '0'`, so every
run with an empty batch skipped it and reported green. Every run that
actually had issues to work through failed identically (runs 30265277395,
30011599875).

daily_ai_fix.yaml: remove it — no trigger of this workflow can ever satisfy
the constraint. Claude still comments per issue via gh, as issue-fix.md
instructs; only the run-level sticky comment is lost.

on_issue_approved.yaml: same latent failure on its workflow_dispatch path,
but the `issues` path is valid, so gate it on the event instead of dropping
it. The action defaults this input to the string "false", so the expression
result is a shape it already handles.

Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 27, 2026 12:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 447bb213-6fa0-4e9e-9cd6-febac9856bca

📥 Commits

Reviewing files that changed from the base of the PR and between 885b055 and 7ff972a.

📒 Files selected for processing (2)
  • .github/workflows/daily_ai_fix.yaml
  • .github/workflows/on_issue_approved.yaml

Walkthrough

The AI workflows now avoid invalid or unsupported Claude action progress tracking: daily fixes omit it, while issue approval runs enable it only for issue events and disable it for manual dispatches.

Changes

AI workflow progress handling

Layer / File(s) Summary
Configure progress tracking by workflow context
.github/workflows/daily_ai_fix.yaml, .github/workflows/on_issue_approved.yaml
The daily fix action no longer enables track_progress; the issue approval action enables it only when triggered by an issue event.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: bug

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the core change: removing or gating track_progress when workflows lack issue/PR context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alexbelgium
alexbelgium merged commit 83aa854 into master Jul 27, 2026
8 checks passed
@alexbelgium
alexbelgium deleted the fix/ci-track-progress-dispatch branch July 27, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants