Repository navigation
fix(ci): drop track_progress where the event has no issue/PR context - #2909
Merged
Merged
Conversation
The AI fix sweep has never completed a non-empty batch. claude-code-action rejects track_progress unless the triggering event is pull_request, issues, issue_comment, pull_request_review_comment or pull_request_review, and daily_ai_fix.yaml only ever runs on schedule or workflow_dispatch. The step died in input validation after 0.3s: Action failed with error: track_progress is only supported for events: pull_request, issues, issue_comment, pull_request_review_comment, pull_request_review. Current event: workflow_dispatch This went unnoticed because the step is gated on `count != '0'`, so every run with an empty batch skipped it and reported green. Every run that actually had issues to work through failed identically (runs 30265277395, 30011599875). daily_ai_fix.yaml: remove it — no trigger of this workflow can ever satisfy the constraint. Claude still comments per issue via gh, as issue-fix.md instructs; only the run-level sticky comment is lost. on_issue_approved.yaml: same latent failure on its workflow_dispatch path, but the `issues` path is valid, so gate it on the event instead of dropping it. The action defaults this input to the string "false", so the expression result is a shape it already handles. Co-Authored-By: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughThe AI workflows now avoid invalid or unsupported Claude action progress tracking: daily fixes omit it, while issue approval runs enable it only for issue events and disable it for manual dispatches. ChangesAI workflow progress handling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
The AI fix sweep has never completed a non-empty batch. Run 30265277395 failed in
Analyse and fixafter ~0.3s, before any analysis happened:track_progressneeds an issue or PR to hang its sticky comment on.daily_ai_fix.yamltriggers only onscheduleandworkflow_dispatch, neither of which has one, soclaude-code-actionrejects the input during validation.Why nobody noticed
The step is gated on
if: steps.batch.outputs.count != '0'. Runs with an empty batch skip it entirely and report green:Analyse and fixEvery green run is a no-op. Every run with issues to work through failed the same way. The 3am cron would fail identically the moment an
ai-triageissue exists — this is not dispatch-only.Changes
daily_ai_fix.yaml— removetrack_progress. No trigger of this workflow can satisfy the constraint, so there is no conditional worth keeping. Per-issue reporting is unaffected:issue-fix.mdalready has Claude comment on each issue viagh. Only the run-level sticky comment is lost.on_issue_approved.yaml— same latent failure on itsworkflow_dispatchpath, but itsissuespath is valid, so gate on the event rather than dropping it:track_progress: ${{ github.event_name == 'issues' }}. The action declares this input's default as the string"false", so the expression result is a shape it already handles.Verification
Both files parse. Not runtime-verified — that needs a dispatch with a non-empty
ai-triagebatch, which is worth doing once this lands.🤖 Generated with Claude Code
Summary by CodeRabbit