Repository navigation
fix(a11y): remove unnecessary mermaid SVG pa11y suppression - #772
3 commits merged into
Conversation
The deduplicateSvgIds build-time transform already handles mermaid's
duplicate internal SVG IDs by prefixing them with svg-{index}-, making
the pa11y suppression unnecessary.
https://claude.ai/code/session_012NWqa8w84wJjBEHJDSmBTF
DeepSource reviewed changes in the commit range For detailed review results, please see the PR on DeepSource ↗ PR Report Card
Code Review Summary
How are these analyzer statuses calculated?Administrators can configure which issue categories are reported and cause analysis to be marked as failed when detected. This helps prevent bad and insecure code from being introduced in the codebase. If you're an administrator, you can modify this in the repository's settings. |
|
Preview deployed for commit 4847e05: This preview updates automatically on each push to this PR. |
|
waiting on mermaid-js/mermaid#5756 and my complementary fix |
Document the full range of accessibility features including keyboard navigation, screen reader support, ARIA usage, color contrast, reduced motion, SVG deduplication, video captions, and automated enforcement. https://claude.ai/code/session_012NWqa8w84wJjBEHJDSmBTF
This reverts commit 2782fe0.
|
note to self: update |
Summary
.mermaid svgfrom pa11yhideElementssince thededuplicateSvgIdsbuild-time transform already fixes duplicate SVG IDsChanges
.mermaid svgentry fromconfig/pa11y/.pa11ycihideElementsarrayTesting
deduplicateSvgIdsfunction ingfm.tshas comprehensive unit tests covering all ID prefixing and reference updating scenarioshttps://claude.ai/code/session_012NWqa8w84wJjBEHJDSmBTF