Skip to content

fix(a11y): remove unnecessary mermaid SVG pa11y suppression - #772

Merged
3 commits merged into
mainfrom
claude/document-accessibility-work-X1h9f
Apr 3, 2026
Merged

3 commits merged into
mainfrom
claude/document-accessibility-work-X1h9f

Conversation

@alexander-turner

Copy link
Copy Markdown
Owner

Summary

  • Remove .mermaid svg from pa11y hideElements since the deduplicateSvgIds build-time transform already fixes duplicate SVG IDs
  • This restores full accessibility checking coverage for mermaid diagrams

Changes

  • Removed .mermaid svg entry from config/pa11y/.pa11yci hideElements array

Testing

  • The deduplicateSvgIds function in gfm.ts has comprehensive unit tests covering all ID prefixing and reference updating scenarios
  • pa11y will now run full accessibility checks on mermaid SVGs, which is the desired behavior

https://claude.ai/code/session_012NWqa8w84wJjBEHJDSmBTF

The deduplicateSvgIds build-time transform already handles mermaid's
duplicate internal SVG IDs by prefixing them with svg-{index}-, making
the pa11y suppression unnecessary.

https://claude.ai/code/session_012NWqa8w84wJjBEHJDSmBTF
@deepsource-io

deepsource-io Bot commented Feb 19, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

DeepSource reviewed changes in the commit range 806ba61...b4b0654 on this pull request. Below is the summary for the review, and you can see the individual issues we found as review comments.

For detailed review results, please see the PR on DeepSource ↗

PR Report Card

Security × 0 issues Overall PR Quality   

Reliability × 0 issues
Complexity × 0 issues
Hygiene × 0 issues

Code Review Summary

Analyzer Status Summary Details
Shell No new issues detected. Review ↗
JavaScript No new issues detected. Review ↗
Python No new issues detected. Review ↗
How are these analyzer statuses calculated?

Administrators can configure which issue categories are reported and cause analysis to be marked as failed when detected. This helps prevent bad and insecure code from being introduced in the codebase. If you're an administrator, you can modify this in the repository's settings.

@github-actions

github-actions Bot commented Feb 19, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployed for commit 4847e05:
https://pr-772.turntrout.pages.dev

This preview updates automatically on each push to this PR.

@alexander-turner

Copy link
Copy Markdown
Owner Author

waiting on mermaid-js/mermaid#5756 and my complementary fix

Document the full range of accessibility features including keyboard
navigation, screen reader support, ARIA usage, color contrast, reduced
motion, SVG deduplication, video captions, and automated enforcement.

https://claude.ai/code/session_012NWqa8w84wJjBEHJDSmBTF
@alexander-turner

Copy link
Copy Markdown
Owner Author

note to self: update design.md with future changes here

@github-actions

Copy link
Copy Markdown
Contributor

@claude The following workflows have failed:

Please investigate and fix the issues.

@alexander-turner alexander-turner closed this pull request by merging all changes into main in 9339c60 Apr 3, 2026
@alexander-turner
alexander-turner deleted the claude/document-accessibility-work-X1h9f branch April 3, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants