Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

fix compilation error: unqualified call to 'std::move' #2053

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AVSCommon/Utils/src/WorkerThread.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ void WorkerThread::cancel() {
void WorkerThread::run(std::function<bool()> workFunc) {
std::lock_guard<std::mutex> lock(m_mutex);
m_cancel = false;
m_workerFunc = move(workFunc);
m_workerFunc = std::move(workFunc);
m_workReady.notify_one();
}

Expand Down
2 changes: 1 addition & 1 deletion AVSGatewayManager/src/AuthRefreshedObserver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ static const string TAG("AuthRefreshedObserver");

AuthRefreshedObserver::AuthRefreshedObserver(function<void()> afterAuthRefreshedCallback) :
m_state{State::UNINITIALIZED},
m_afterAuthRefreshedCallback{move(afterAuthRefreshedCallback)} {
m_afterAuthRefreshedCallback{std::move(afterAuthRefreshedCallback)} {
}

shared_ptr<AuthRefreshedObserver> alexaClientSDK::avsGatewayManager::AuthRefreshedObserver::create(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,13 @@ shared_ptr<DavsRequest> DavsRequest::create(string type, string key, FilterMap f
}
}

return unique_ptr<DavsRequest>(new DavsRequest(move(type), move(key), move(filters), endpoint, unpack));
return unique_ptr<DavsRequest>(new DavsRequest(std::move(type), std::move(key), std::move(filters), endpoint, unpack));
}

DavsRequest::DavsRequest(string type, string key, FilterMap filters, Region endpoint, bool unpack) :
m_type(move(type)),
m_key(move(key)),
m_filters(move(filters)),
m_type(std::move(type)),
m_key(std::move(key)),
m_filters(std::move(filters)),
m_region(endpoint),
m_unpack(unpack) {
m_summary = this->m_type + "_" + this->m_key;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ shared_ptr<UrlRequest> UrlRequest::create(string url, string filename, bool unpa
ACSDK_INFO(LX("create").m("Using custom cert from path").d("path", certPath));
}

return unique_ptr<UrlRequest>(new UrlRequest(move(url), move(filename), unpack, move(certPath)));
return unique_ptr<UrlRequest>(new UrlRequest(std::move(url), std::move(filename), unpack, std::move(certPath)));
}

UrlRequest::UrlRequest(string url, string filename, bool unpack, string certPath) :
m_url(move(url)),
m_filename(move(filename)),
m_url(std::move(url)),
m_filename(std::move(filename)),
m_unpack(unpack),
m_certPath(certPath),
m_certHash(certPath.empty() ? "" : getHash(certPath)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,14 @@ unique_ptr<VendableArtifact> VendableArtifact::create(
uuid += "_unpack";
}
return unique_ptr<VendableArtifact>(new VendableArtifact(
move(request),
move(id),
std::move(request),
std::move(id),
artifactSizeBytes,
artifactExpiry,
move(s3Url),
std::move(s3Url),
urlExpiry,
currentSizeBytes,
move(uuid),
std::move(uuid),
multipart));
}

Expand Down Expand Up @@ -160,7 +160,7 @@ unique_ptr<VendableArtifact> VendableArtifact::create(
}

return create(
move(request),
std::move(request),
id,
size,
TimeEpoch(chrono::milliseconds(ttl)),
Expand All @@ -180,14 +180,14 @@ VendableArtifact::VendableArtifact(
size_t currentSizeBytes,
string uuid,
bool multipart) :
m_request(move(request)),
m_id(move(id)),
m_request(std::move(request)),
m_id(std::move(id)),
m_artifactSizeBytes(artifactSizeBytes),
m_artifactExpiry(artifactExpiry),
m_s3Url(move(s3Url)),
m_s3Url(std::move(s3Url)),
m_urlExpiry(urlExpiry),
m_currentSizeBytes(currentSizeBytes),
m_uuid(move(uuid)),
m_uuid(std::move(uuid)),
m_multipart(multipart) {
}

Expand Down