-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validator update from 9.0.0 to 13.7.0 #52
Conversation
Remediates CVE-2021-3765
@mreinstein I've noticed that I don't see the CI action workflow executing when new PRs are made. Is this intentional? |
Currently it only runs on pushes to the alexa-verifier-middleware/.github/workflows/main.yml Lines 7 to 9 in 417f4eb
|
I've updated the workflow to run on PR activity now. |
Hello. Hoping someone is already reviewing this PR. |
@Reni88 can you please rebase so we can see CI/CD kick after @mreinstein's fix of the workflow file? |
package-lock.json
Outdated
@@ -1,12 +1,12 @@ | |||
{ | |||
"name": "alexa-verifier-middleware", | |||
"version": "2.0.1", | |||
"version": "2.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we had released 2.0.2 before, so this should be 2.0.3, the next developer iteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had changes this to 2.0.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I need to update package.json and changeLog too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Update version of alexa-verifier-middleware in package-lock.json
Remediates CVE-2021-3765 by updating validator package version
@dblock LGTM! You may merge when ready. |
@tejashah88 you too :) |
As this is merged, @tejashah88 or @dblock , when can we expect it'll be updated in npmjs? |
Remediates CVE-2021-3765