Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 fixes #35 #42

Merged
merged 3 commits into from
Jan 15, 2022
Merged

v2 fixes #35 #42

merged 3 commits into from
Jan 15, 2022

Conversation

mreinstein
Copy link
Collaborator

  • convert to pure es module
  • remove old versions of node (< 12)
  • enforce node version as a required thing via .npmrc
  • update all deps
  • update readme
  • add changelog

@mreinstein mreinstein mentioned this pull request Jan 13, 2022
Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tejashah88
Copy link
Member

tejashah88 commented Jan 14, 2022

@mreinstein It seems that the automated Travis builds are not happening due to a change in their pricing structure and website. Can you verify the tests on your machine and update them as needed?

@mreinstein
Copy link
Collaborator Author

Yeah I saw that too. I was trying to update to travis.com but that didn't solve it. I guess time to expore github actions?

@mreinstein mreinstein merged commit f881f5c into master Jan 15, 2022
@tejashah88
Copy link
Member

@mreinstein Thank you for your work! I guess it's indeed time to explore GitHub actions

@mreinstein
Copy link
Collaborator Author

I started switching all my personal projects over to it. I do hesitate a little, relying on more github services/features because it means I'm more tied to them, but I guess the same could be said of travis, and it's definitely a simpler integration.

@tejashah88
Copy link
Member

I agree with your sentiment. It's a limitation that we'll have to accept on the name of using free services and a relatively easy dev experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants