Fix incorrect parsing of binary expressions (fixes #153)

[ketkarameya]

Should I apply this similar pattern for other binary operators too? Or is there a nicer way to do it :O ?

[alex-pinkus]

Interesting, it looks like this causes a parse failure at https://github.com/groue/GRDB.swift/blob/4472d3a60ec4cc383503eba5072ce17f781b9ddc/GRDB/QueryInterface/SQLGeneration/SQLQueryGenerator.swift#L86 — possibly related to the binary expression that starts on line 77 if it changes the way that gets parsed?

[ketkarameya]

I wonder why this fails :| I tried a very basic if try which throws an error.

func doSomething() {
    if try something {
        return a
    }
    return defaultValue
}

I couldn't find where if try is handled. Is it missing?
Would we need something similar to _if_let_binding?
I observed that this scenario worked before my change, so it is this new change that has caused this failure :|

---

I saw that just try works alright. if try is the problem.

[alex-pinkus]

Nice, you got it working! I blame swift for this ambiguity — whoever thought that “if statements without parentheses” and “trailing closures” belonged in the same language together were clearly not thinking for the long term.

[alex-pinkus]

This all looks good to me, so I’m happy to merge it later tonight. If you’d like, you can also amend to clean up the git commits and then git push origin with --force so that the reverts don’t show up in the history. Just let me know whether you’d like to do that and I can merge it after!

[ketkarameya]

Done. I have cleaned the history. Please merge the request. :)

[alex-pinkus]

Done! Thank you so much for fixing this!