Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the default ABI on the with-generated-files branch #352

Closed
the-mikedavis opened this issue Feb 8, 2024 · 2 comments · Fixed by #355
Closed

Switch the default ABI on the with-generated-files branch #352

the-mikedavis opened this issue Feb 8, 2024 · 2 comments · Fixed by #355

Comments

@the-mikedavis
Copy link

Hey hey @alex-pinkus 👋

I see that the src/parser.c on the with-generated-files branch is on ABI 13:

# Now that we know the parser works, build for ABI 14 (but don't use this as the default because
# it's not compatible everywhere).
mv src/parser.c src/parser_abi13.c
npx tree-sitter generate --abi 14
mv src/parser.c src/parser_abi14.c
mv src/parser_abi13.c src/parser.c

What do you think about swapping it so that ABI 14 is the new default? 14 has been around for a while now and I don't know of any holdouts that are still only compatible with 13.

@alex-pinkus
Copy link
Owner

👋🏻

Off the top of my head, I think I was waiting for the emacs plugin to switch over — that was on tree-sitter 0.19 last I checked. They had never officially switched over to this grammar but I know some folks had gotten it working.

Quick googling tells me that the landscape has changed and tree-sitter support is now built into emacs itself, so I assume it’s a newer version. Before I do too much digging, do you happen to know whether that’s using ABI 14?

@the-mikedavis
Copy link
Author

I'm not very familiar with emacs' codebase but poking around a little I see this: https://git.savannah.gnu.org/cgit/emacs.git/tree/configure.ac#n4029

Looks like they require at least 0.20.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants